Skip to content

[Merged by Bors] - chore: Run lake exe shake --update#13657

Closed
YaelDillies wants to merge 1 commit intomasterfrom
noshake
Closed

[Merged by Bors] - chore: Run lake exe shake --update#13657
YaelDillies wants to merge 1 commit intomasterfrom
noshake

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies commented Jun 9, 2024

Seems like shake wants to move things around due to the Std/Batteries rename, so I'm running lake exe shake --update now to avoid polluting later PRs.


Open in Gitpod

Seems like shake wants to move things around, so I'm running `lake exe shake --update` now to avoid polluting later PRs.
@YaelDillies YaelDillies added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. labels Jun 9, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 9, 2024

PR summary

Import changes

No significant changes to the import graph


Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I checked that all lines are only moved.
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 9, 2024

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 9, 2024
@eric-wieser
Copy link
Copy Markdown
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 9, 2024
Seems like shake wants to move things around due to the `Std`/`Batteries` rename, so I'm running `lake exe shake --update` now to avoid polluting later PRs.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Run lake exe shake --update [Merged by Bors] - chore: Run lake exe shake --update Jun 9, 2024
@mathlib-bors mathlib-bors bot closed this Jun 9, 2024
@mathlib-bors mathlib-bors bot deleted the noshake branch June 9, 2024 12:00
AntoineChambert-Loir pushed a commit that referenced this pull request Jun 20, 2024
Seems like shake wants to move things around due to the `Std`/`Batteries` rename, so I'm running `lake exe shake --update` now to avoid polluting later PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants