[Merged by Bors] - chore: Move the inheritance StrictOrderedSemiring α → CharZero α instance to a less obscure file#13654
Closed
YaelDillies wants to merge 2 commits intomasterfrom
Closed
Conversation
…stance to a less obscure file There is little point in avoiding to import `CharZero` in `Algebra.Order.Ring.Defs` since it is so basic. Exiling the titular basic instance to an obscure file meant that people had trouble finding that instance (and it just happened to Eric).
PR summaryImport changesDependency changes
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Member
|
bors d+ This dependency does seem pretty lightweight; can you justify in the PR description why it should go here and not even earlier? |
Contributor
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
This is the earliest file it can go in since |
Contributor
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 9, 2024
…stance to a less obscure file (#13654) There is little point in avoiding to import `CharZero` in `Algebra.Order.Ring.Defs` (where `StrictOrderedSemiring` is defined) since it is so basic. Exiling the titular basic instance to an obscure file meant that people had trouble finding that instance (and it just happened to Eric).
Contributor
|
Pull request successfully merged into master. Build succeeded: |
StrictOrderedSemiring α → CharZero α instance to a less obscure fileStrictOrderedSemiring α → CharZero α instance to a less obscure file
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
…stance to a less obscure file (#13654) There is little point in avoiding to import `CharZero` in `Algebra.Order.Ring.Defs` (where `StrictOrderedSemiring` is defined) since it is so basic. Exiling the titular basic instance to an obscure file meant that people had trouble finding that instance (and it just happened to Eric).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is little point in avoiding to import
CharZeroinAlgebra.Order.Ring.Defs(whereStrictOrderedSemiringis defined) since it is so basic. Exiling the titular basic instance to an obscure file meant that people had trouble finding that instance (and it just happened to Eric).