[Merged by Bors] - chore: Add floor_ofNat and ceil_ofNat#13645
Closed
eric-wieser wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - chore: Add floor_ofNat and ceil_ofNat#13645eric-wieser wants to merge 4 commits intomasterfrom
eric-wieser wants to merge 4 commits intomasterfrom
Conversation
PR summaryImport changesNo significant changes to the import graph Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
YaelDillies
approved these changes
Jun 9, 2024
| #align nat.floor_coe Nat.floor_coe | ||
| #align nat.floor_coe Nat.floor_natCast | ||
|
|
||
| @[deprecated (since := "2024-06-08")] alias floor_coe := floor_natCast |
Contributor
There was a problem hiding this comment.
Have you heard about the new deprecated alias code snippet btw?
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Contributor
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 9, 2024
Also renames `Nat.floor_coe` to `floor_natCast`, leaving behind a deprecation.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
Also renames `Nat.floor_coe` to `floor_natCast`, leaving behind a deprecation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also renames
Nat.floor_coetofloor_natCast, leaving behind a deprecation.