Skip to content

[Merged by Bors] - chore(Order/Atoms): Rename instances according to convention#13643

Closed
YaelDillies wants to merge 1 commit intomasterfrom
order_dual_atomic
Closed

[Merged by Bors] - chore(Order/Atoms): Rename instances according to convention#13643
YaelDillies wants to merge 1 commit intomasterfrom
order_dual_atomic

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies commented Jun 8, 2024

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. labels Jun 8, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 8, 2024

PR summary

Import changes

No significant changes to the import graph

Declarations diff

+ OrderDual.instIsSimpleOrder
+ instance _root_.OrderDual.instIsAtomic : IsAtomic αᵒᵈ
+ instance _root_.OrderDual.instIsAtomistic [h : IsCoatomistic α] : IsAtomistic αᵒᵈ
+ instance _root_.OrderDual.instIsCoatomic : IsCoatomic αᵒᵈ
+ instance _root_.OrderDual.instIsCoatomistic [h : IsAtomistic α] : IsCoatomistic αᵒᵈ
- instance {α} [LE α] [BoundedOrder α] [IsSimpleOrder α] : IsSimpleOrder αᵒᵈ
- isAtomistic_dual
- isCoatomic
- isCoatomic_dual
- isCoatomistic_dual

You can run this locally as follows 
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@YaelDillies YaelDillies mentioned this pull request Jun 8, 2024
Closed
grunweg
grunweg reviewed Jun 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 9, 2024

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 9, 2024
@sgouezel
Copy link
Copy Markdown
Contributor

sgouezel commented Jun 9, 2024

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 9, 2024
@YaelDillies
chore(Order/Atoms): Rename instances according to convention (#13643)
88a31a9
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Order/Atoms): Rename instances according to convention [Merged by Bors] - chore(Order/Atoms): Rename instances according to convention Jun 9, 2024
@mathlib-bors mathlib-bors bot closed this Jun 9, 2024
@mathlib-bors mathlib-bors bot deleted the order_dual_atomic branch June 9, 2024 09:02
AntoineChambert-Loir pushed a commit that referenced this pull request Jun 20, 2024
@YaelDillies @AntoineChambert-Loir
chore(Order/Atoms): Rename instances according to convention (#13643)
59b6d59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grunweg grunweg grunweg left review comments

Assignees

No one assigned

Labels

easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YaelDillies @sgouezel @grunweg