Skip to content

[Merged by Bors] - chore(Data/Tree): split file#13629

Closed
urkud wants to merge 6 commits intomasterfrom
YK-data-tree
Closed

[Merged by Bors] - chore(Data/Tree): split file#13629
urkud wants to merge 6 commits intomasterfrom
YK-data-tree

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Jun 8, 2024

Move 3 definitions that depend on Num to a new file.


Open in Gitpod

Move 3 definitions that depend on `Num` to a new file.
@urkud urkud added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jun 8, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 8, 2024

PR summary

Import changes

Dependency changes

File Base Count Head Count Change
Mathlib.Tactic.CancelDenoms.Core 362 358 -4 (-1.10%)
Mathlib.Combinatorics.Enumerative.Catalan 654 652 -2 (-0.31%)

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Needs shake applied and I have two nits. Thanks!

This there was a maintainer delegate, I'd use this now.

urkud and others added 2 commits June 8, 2024 09:42
Co-authored-by: grunweg <rothgami@math.hu-berlin.de>
@urkud
Copy link
Copy Markdown
Member Author

urkud commented Jun 8, 2024

I followed @grunweg 's suggestions, so let me
maintainer merge
my own PR

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 8, 2024

🚀 Pull request has been placed on the maintainer queue by urkud.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 8, 2024
@urkud
Copy link
Copy Markdown
Member Author

urkud commented Jun 8, 2024

Sorry, lake exe shake was too aggressive.

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 8, 2024
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 8, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 8, 2024
Move 3 definitions that depend on `Num` to a new file.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 8, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Data/Tree): split file [Merged by Bors] - chore(Data/Tree): split file Jun 8, 2024
@mathlib-bors mathlib-bors bot closed this Jun 8, 2024
@mathlib-bors mathlib-bors bot deleted the YK-data-tree branch June 8, 2024 19:30
AntoineChambert-Loir pushed a commit that referenced this pull request Jun 20, 2024
Move 3 definitions that depend on `Num` to a new file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants