Skip to content

[Merged by Bors] - chore(*): fix formatting of some deprecation dates#13626

Closed
urkud wants to merge 5 commits intomasterfrom
YK-deprecated-dates
Closed

[Merged by Bors] - chore(*): fix formatting of some deprecation dates#13626
urkud wants to merge 5 commits intomasterfrom
YK-deprecated-dates

Conversation

@urkud
Copy link
Copy Markdown
Member

@urkud urkud commented Jun 8, 2024


Open in Gitpod

@urkud urkud added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jun 8, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 8, 2024

PR summary

Import changes

No significant changes to the import graph


Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 8, 2024
@urkud urkud added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Jun 8, 2024
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! I found three tweaks, which are all minor and optional
maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 8, 2024

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 8, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 8, 2024

🚀 Pull request has been placed on the maintainer queue by grunweg.

Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 8, 2024
@eric-wieser
Copy link
Copy Markdown
Member

bors r-

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 8, 2024

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 8, 2024

Canceled.

@github-actions github-actions bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jun 8, 2024
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 8, 2024
@urkud
Copy link
Copy Markdown
Member Author

urkud commented Jun 8, 2024

bors merge

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 8, 2024

👎 Rejected by label

@urkud urkud removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 8, 2024
@urkud
Copy link
Copy Markdown
Member Author

urkud commented Jun 8, 2024

bors merge

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 8, 2024

Build failed:

This partially reverts commit
07d6848.
`not_mem_tsupport_iff_eventuallyEq` is not available in this file.
@urkud urkud added the auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. label Jun 8, 2024
@ghost
Copy link
Copy Markdown

ghost commented Jun 8, 2024

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 8, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(*): fix formatting of some deprecation dates [Merged by Bors] - chore(*): fix formatting of some deprecation dates Jun 8, 2024
@mathlib-bors mathlib-bors bot closed this Jun 8, 2024
@mathlib-bors mathlib-bors bot deleted the YK-deprecated-dates branch June 8, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants