Skip to content

[Merged by Bors] - chore: tidy induction principles for Unitization and TrivSqZeroExt#13476

Closed
eric-wieser wants to merge 2 commits intomasterfrom
eric-wieser/tsze-unitization-ind
Closed

[Merged by Bors] - chore: tidy induction principles for Unitization and TrivSqZeroExt#13476
eric-wieser wants to merge 2 commits intomasterfrom
eric-wieser/tsze-unitization-ind

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

This adds elab_as_elim, induction_eliminator, and cases_eliminator attributes, which eliminates the need to use the using term of induction.

Also choose a better argument name, since this is used as the case name.

Split from #12605


Open in Gitpod

This adds `elab_as_elim`, `induction_eliminator`, and `cases_eliminator` attributes,
which eliminates the need to use the `using` term of `induction`.

Also choose a better argument name, since this is used as the case name.
@eric-wieser eric-wieser added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jun 3, 2024
@eric-wieser eric-wieser requested a review from j-loreaux June 3, 2024 08:45
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 3, 2024
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 3, 2024

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Jun 3, 2024
@dupuisf
Copy link
Copy Markdown
Contributor

dupuisf commented Jun 3, 2024

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 3, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 3, 2024
…13476)

This adds `elab_as_elim`, `induction_eliminator`, and `cases_eliminator` attributes, which eliminates the need to use the `using` term of `induction`.

Also choose a better argument name, since this is used as the case name.

Split from #12605
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jun 4, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: tidy induction principles for Unitization and TrivSqZeroExt [Merged by Bors] - chore: tidy induction principles for Unitization and TrivSqZeroExt Jun 4, 2024
@mathlib-bors mathlib-bors bot closed this Jun 4, 2024
@mathlib-bors mathlib-bors bot deleted the eric-wieser/tsze-unitization-ind branch June 4, 2024 00:14
callesonne pushed a commit that referenced this pull request Jun 4, 2024
…13476)

This adds `elab_as_elim`, `induction_eliminator`, and `cases_eliminator` attributes, which eliminates the need to use the `using` term of `induction`.

Also choose a better argument name, since this is used as the case name.

Split from #12605
grunweg pushed a commit that referenced this pull request Jun 7, 2024
…13476)

This adds `elab_as_elim`, `induction_eliminator`, and `cases_eliminator` attributes, which eliminates the need to use the `using` term of `induction`.

Also choose a better argument name, since this is used as the case name.

Split from #12605
AntoineChambert-Loir pushed a commit that referenced this pull request Jun 20, 2024
…13476)

This adds `elab_as_elim`, `induction_eliminator`, and `cases_eliminator` attributes, which eliminates the need to use the `using` term of `induction`.

Also choose a better argument name, since this is used as the case name.

Split from #12605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants