Closed
Conversation
#12061 regressed this file pretty badly; try to speed it up again
add three shortcut instance to speed up TC search squeeze some simps (sometimes, avoids TC search!) avoid expensive convert when easily possible
Contributor
Author
|
!bench |
To be discussed if this is actually beneficial, or more subtle than I thought!
27d3c67 to
1b79358
Compare
Collaborator
|
Here are the benchmark results for commit 27d3c67. |
- squeeze nlinarith calls (saves 1s each) - squeeze simp (saves 0.5s) - downgrade congr! to congr (saves ~0.1s)
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit c5282de. Benchmark Metric Change
===============================================================================
+ ~Mathlib.Geometry.Manifold.Instances.Sphere instructions -30.5%
+ ~Mathlib.Geometry.Manifold.VectorBundle.FiberwiseLinear instructions -38.7% |
Contributor
Author
|
The changes in LeftInvariantDerivation do speed up the file, but very slightly (2-3%). |
Each declaration changed is sped up at least by a factor of two.
PR summary 766a40b592Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small reductions in
LeftInvariantDerivation(2%, 4,5 * 10⁹ instructions) andContMDiff.Defs(2,5%, 1,5 * 10⁹ instructions).Comments welcome if these are worth it.
Includes #13456.