[Merged by Bors] - feat: lint on isolated where and leading by#13420
Closed
[Merged by Bors] - feat: lint on isolated where and leading by#13420
Conversation
53d21be to
60baf6d
Compare
d79a64f to
ec2e6fd
Compare
PR summary a0b54d8996Import changesNo significant changes to the import graph Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Member
|
This looks reasonable to me, thanks! Delegating in case there are any errors introduced since the last update. bors d+ |
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
380c92d to
a0b54d8
Compare
Contributor
Author
|
Thank you for the review! There was one new occurrence, which I have just auto-fixed. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
Extend the style linter with two tiny features: - lint on "isolated where": all occurrences were already fixed in #12991 and #13202. - lint on "leading by": if one line starts with `by ` but the previous line ends with `:=`, according to the style guide the `by` should move to the previous line. For now, we only lint if the `by` fits on the previous line (fixed in #13618 and predecessors): there about other 28 cases in mathlib which don't have an obvious fix.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
Extend the style linter with two tiny features: - lint on "isolated where": all occurrences were already fixed in #12991 and #13202. - lint on "leading by": if one line starts with `by ` but the previous line ends with `:=`, according to the style guide the `by` should move to the previous line. For now, we only lint if the `by` fits on the previous line (fixed in #13618 and predecessors): there about other 28 cases in mathlib which don't have an obvious fix.
grunweg
added a commit
that referenced
this pull request
Jun 20, 2024
Extend the style linter with two tiny features: - lint on "isolated where": all occurrences were already fixed in #12991 and #13202. - lint on "leading by": if one line starts with `by ` but the previous line ends with `:=`, according to the style guide the `by` should move to the previous line. For now, we only lint if the `by` fits on the previous line (fixed in #13618 and predecessors): there about other 28 cases in mathlib which don't have an obvious fix.
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
Extend the style linter with two tiny features: - lint on "isolated where": all occurrences were already fixed in #12991 and #13202. - lint on "leading by": if one line starts with `by ` but the previous line ends with `:=`, according to the style guide the `by` should move to the previous line. For now, we only lint if the `by` fits on the previous line (fixed in #13618 and predecessors): there about other 28 cases in mathlib which don't have an obvious fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the style linter with two tiny features:
where#12991 and [Merged by Bors] - style: remove last isolated where #13202.bybut the previous line ends with:=, according to the style guide thebyshould move to the previous line. For now, we only lint if thebyfits on the previous line (fixed in [Merged by Bors] - style: fix last easy isolatedbys #13618 and predecessors): there about other 28 cases in mathlib which don't have an obvious fix.