[Merged by Bors] - chore: restore cc tactic#13404
Closed
Conversation
Contributor
|
!bench |
Collaborator
|
Here are the benchmark results for commit 9a22571. |
|
This PR/issue depends on: |
PR summary 29a065f2ac
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Logic.Equiv.Basic | 142 | 153 | +11 (+7.75%) |
| Mathlib.Logic.Embedding.Basic | 147 | 158 | +11 (+7.48%) |
| Mathlib.Data.Num.Lemmas | 450 | 457 | +7 (+1.56%) |
| Mathlib.Data.PFunctor.Multivariate.M | 503 | 510 | +7 (+1.39%) |
| Mathlib.SetTheory.Ordinal.Arithmetic | 572 | 579 | +7 (+1.22%) |
| Mathlib.LinearAlgebra.Basic | 655 | 662 | +7 (+1.07%) |
| Mathlib.LinearAlgebra.Multilinear.Basic | 676 | 683 | +7 (+1.04%) |
| Mathlib.Data.Matrix.Block | 773 | 780 | +7 (+0.91%) |
| Mathlib.Data.Matrix.PEquiv | 774 | 781 | +7 (+0.90%) |
| Mathlib.NumberTheory.Bernoulli | 1066 | 1072 | +6 (+0.56%) |
| Mathlib.Analysis.Convex.SpecificFunctions.Deriv | 1528 | 1534 | +6 (+0.39%) |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>
Ruben-VandeVelde
approved these changes
Jun 23, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
This seems reasonable
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 23, 2024
The `cc` tactic is a high-cost tactic, so I restored `cc` tactics only if a proof can be reduced significantly. I made sure that `cc` tactic works on in the all changed proofs except when the other specification changes in Lean 4 changes a goal. Co-authored-by: Pol'tta / Miyahara Kō <52843868+Komyyy@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
cc tacticcc tactic
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
The `cc` tactic is a high-cost tactic, so I restored `cc` tactics only if a proof can be reduced significantly. I made sure that `cc` tactic works on in the all changed proofs except when the other specification changes in Lean 4 changes a goal. Co-authored-by: Pol'tta / Miyahara Kō <52843868+Komyyy@users.noreply.github.com>
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
The `cc` tactic is a high-cost tactic, so I restored `cc` tactics only if a proof can be reduced significantly. I made sure that `cc` tactic works on in the all changed proofs except when the other specification changes in Lean 4 changes a goal. Co-authored-by: Pol'tta / Miyahara Kō <52843868+Komyyy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cctactic is a high-cost tactic, so I restoredcctactics only if a proof can be reduced significantly.I made sure that
cctactic works on in the all changed proofs except when the other specification changes in Lean 4 changes a goal.cctactic can't unify def-eq instances inOfNat.ofNat#13403