Conversation
|
This PR/issue depends on: |
dagurtomas
reviewed
Aug 12, 2024
dagurtomas
approved these changes
Aug 12, 2024
Contributor
dagurtomas
left a comment
There was a problem hiding this comment.
I admit that I didn't read the proofs closely, but the statements look good, the file is structured nicely and is reasonably fast. I just had one minor comment about a docstring, otherwise LGTM. Maybe it's best also to merge master before this is sent to bors, since it's been sitting for a while.
Co-authored-by: Dagur Asgeirsson <dagurtomas@gmail.com>
Contributor
|
Thanks! maintainer merge |
Contributor
|
Let's try again: maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by dagurtomas. |
Member
|
Thanks 🎉 bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
Defines Hopf monoids in a braided category. Proves two facts (antipode is an antihomomorphism, morphisms intertwine antipode) that are not yet proved for unbundled Hopf algebras. Once we prove `Hopf_ (ModuleCat R)` is equivalent to `HopfAlgebraCat` (having defined that!), we will get those two facts for free. We should also check later that `Hopf_ C` in a cartesian monoidal category is equivalent `GroupObject_ C` (being defined independently elsewhere). - [x] depends on: #13313 - [x] depends on: #13312 (probably doesn't actually depend, but I don't want to sort out the git history now) - [x] depends on: #13315 Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Joël Riou <joel.riou@universite-paris-saclay.fr>
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
Defines Hopf monoids in a braided category. Proves two facts (antipode is an antihomomorphism, morphisms intertwine antipode) that are not yet proved for unbundled Hopf algebras. Once we prove `Hopf_ (ModuleCat R)` is equivalent to `HopfAlgebraCat` (having defined that!), we will get those two facts for free. We should also check later that `Hopf_ C` in a cartesian monoidal category is equivalent `GroupObject_ C` (being defined independently elsewhere). - [x] depends on: #13313 - [x] depends on: #13312 (probably doesn't actually depend, but I don't want to sort out the git history now) - [x] depends on: #13315 Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Joël Riou <joel.riou@universite-paris-saclay.fr>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
Defines Hopf monoids in a braided category. Proves two facts (antipode is an antihomomorphism, morphisms intertwine antipode) that are not yet proved for unbundled Hopf algebras. Once we prove `Hopf_ (ModuleCat R)` is equivalent to `HopfAlgebraCat` (having defined that!), we will get those two facts for free. We should also check later that `Hopf_ C` in a cartesian monoidal category is equivalent `GroupObject_ C` (being defined independently elsewhere). - [x] depends on: #13313 - [x] depends on: #13312 (probably doesn't actually depend, but I don't want to sort out the git history now) - [x] depends on: #13315 Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Joël Riou <joel.riou@universite-paris-saclay.fr>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
Defines Hopf monoids in a braided category. Proves two facts (antipode is an antihomomorphism, morphisms intertwine antipode) that are not yet proved for unbundled Hopf algebras. Once we prove `Hopf_ (ModuleCat R)` is equivalent to `HopfAlgebraCat` (having defined that!), we will get those two facts for free. We should also check later that `Hopf_ C` in a cartesian monoidal category is equivalent `GroupObject_ C` (being defined independently elsewhere). - [x] depends on: #13313 - [x] depends on: #13312 (probably doesn't actually depend, but I don't want to sort out the git history now) - [x] depends on: #13315 Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Joël Riou <joel.riou@universite-paris-saclay.fr>
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
Defines Hopf monoids in a braided category. Proves two facts (antipode is an antihomomorphism, morphisms intertwine antipode) that are not yet proved for unbundled Hopf algebras. Once we prove `Hopf_ (ModuleCat R)` is equivalent to `HopfAlgebraCat` (having defined that!), we will get those two facts for free. We should also check later that `Hopf_ C` in a cartesian monoidal category is equivalent `GroupObject_ C` (being defined independently elsewhere). - [x] depends on: #13313 - [x] depends on: #13312 (probably doesn't actually depend, but I don't want to sort out the git history now) - [x] depends on: #13315 Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Joël Riou <joel.riou@universite-paris-saclay.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines Hopf monoids in a braided category.
Proves two facts (antipode is an antihomomorphism, morphisms intertwine antipode) that are not yet proved for unbundled Hopf algebras. Once we prove
Hopf_ (ModuleCat R)is equivalent toHopfAlgebraCat(having defined that!), we will get those two facts for free.We should also check later that
Hopf_ Cin a cartesian monoidal category is equivalentGroupObject_ C(being defined independently elsewhere).