[Merged by Bors] - chore: TODOs in Data#13227
Closed
BoltonBailey wants to merge 4 commits intomasterfrom
Closed
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Member
|
Thanks! 🎉 |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 26, 2024
Handles TODOs in the TLD of `Mathlib/Data`. Some finished ones are removed, and some others are put at the top of the file, so that they can be better seen in potential future good-first-issue issues that reference these. * Removes TODO about `FinMap.all` returning `false` for empty `FinMap`s, since it should and does return `true`. * Moved comment about syntax of `Rel.comp` to module docstring. * Removed TODO comment about `Rel.image` definition with bounded quantification in corelib, since it is now defined that way, and the commented lemma can indeed now be proven with `rfl`, (not so for `preimage`, but I believe the existing definition in terms of `image` has advantages) * Moved TODO about `Traversible` for Trees to top of file.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
DataData
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
Handles TODOs in the TLD of `Mathlib/Data`. Some finished ones are removed, and some others are put at the top of the file, so that they can be better seen in potential future good-first-issue issues that reference these. * Removes TODO about `FinMap.all` returning `false` for empty `FinMap`s, since it should and does return `true`. * Moved comment about syntax of `Rel.comp` to module docstring. * Removed TODO comment about `Rel.image` definition with bounded quantification in corelib, since it is now defined that way, and the commented lemma can indeed now be proven with `rfl`, (not so for `preimage`, but I believe the existing definition in terms of `image` has advantages) * Moved TODO about `Traversible` for Trees to top of file.
js2357
pushed a commit
that referenced
this pull request
Jun 18, 2024
Handles TODOs in the TLD of `Mathlib/Data`. Some finished ones are removed, and some others are put at the top of the file, so that they can be better seen in potential future good-first-issue issues that reference these. * Removes TODO about `FinMap.all` returning `false` for empty `FinMap`s, since it should and does return `true`. * Moved comment about syntax of `Rel.comp` to module docstring. * Removed TODO comment about `Rel.image` definition with bounded quantification in corelib, since it is now defined that way, and the commented lemma can indeed now be proven with `rfl`, (not so for `preimage`, but I believe the existing definition in terms of `image` has advantages) * Moved TODO about `Traversible` for Trees to top of file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles TODOs in the TLD of
Mathlib/Data. Some finished ones are removed, and some others are put at the top of the file, so that they can be better seen in potential future good-first-issue issues that reference these.FinMap.allreturningfalsefor emptyFinMaps, since it should and does returntrue.Rel.compto module docstring.Rel.imagedefinition with bounded quantification in corelib, since it is now defined that way, and the commented lemma can indeed now be proven withrfl, (not so forpreimage, but I believe the existing definition in terms ofimagehas advantages)Traversiblefor Trees to top of file.