[Merged by Bors] - chore: fix formatting of many misplaced "by"s#13204
Closed
[Merged by Bors] - chore: fix formatting of many misplaced "by"s#13204
Conversation
This fixes the worst cases, where the 'by' was not even indented correctly.
This will make some lines too long; I can correct those manually.
15 tasks
Member
|
bors merge I'm not really sure this is a good use of:
vs investing in a formatting script and using it in CI. But since you already made the change, let's just put it in. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 31, 2024
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com> Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Contributor
Author
|
Thanks for the review and reminding me of this perspective. You have already successfully installed this voice in my head; I did in fact think about this :-)
Given I won't outdo Mario's future auto-formatter, I'm not convinced trying to develop one myself is the right way to go. |
Contributor
Author
|
#13419 does some more replacements, but in a fully automated way. |
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com> Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.