Skip to content

[Merged by Bors] - chore: fix formatting of many misplaced "by"s#13204

Closed
grunweg wants to merge 9 commits intomasterfrom
MR-more-misplaced-by
Closed

[Merged by Bors] - chore: fix formatting of many misplaced "by"s#13204
grunweg wants to merge 9 commits intomasterfrom
MR-more-misplaced-by

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented May 25, 2024


Open in Gitpod

grunweg added 4 commits May 25, 2024 13:49
This fixes the worst cases, where the 'by' was not even indented correctly.
This will make some lines too long; I can correct those manually.
@grunweg grunweg added the help-wanted The author needs attention to resolve issues label May 25, 2024
@ghost ghost added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 25, 2024
@ghost ghost added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) blocked-by-other-PR labels May 27, 2024
@ghost ghost added the blocked-by-other-PR label May 28, 2024
@ghost ghost removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label May 30, 2024
@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 30, 2024
@Parcly-Taxel Parcly-Taxel removed the help-wanted The author needs attention to resolve issues label May 30, 2024
@grunweg grunweg added awaiting-review tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels May 30, 2024
@grunweg grunweg changed the title chore: fix more misplaced "by" chore: fix formatting of my misplaced "by" May 30, 2024
@grunweg grunweg changed the title chore: fix formatting of my misplaced "by" chore: fix formatting of many misplaced "by"s May 30, 2024
@eric-wieser
Copy link
Copy Markdown
Member

bors merge

I'm not really sure this is a good use of:

  • Your time
  • The reviewers time
  • Other contributors who have merge conflicts to solve after this PR
  • CI time

vs investing in a formatting script and using it in CI.

But since you already made the change, let's just put it in.

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels May 31, 2024
mathlib-bors bot pushed a commit that referenced this pull request May 31, 2024
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 31, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: fix formatting of many misplaced "by"s [Merged by Bors] - chore: fix formatting of many misplaced "by"s May 31, 2024
@mathlib-bors mathlib-bors bot closed this May 31, 2024
@mathlib-bors mathlib-bors bot deleted the MR-more-misplaced-by branch May 31, 2024 01:12
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented May 31, 2024

Thanks for the review and reminding me of this perspective. You have already successfully installed this voice in my head; I did in fact think about this :-)

  • on using my time, the initial changes were fully automatic
  • my next step, instead of hand-fixing these, would have been to add an extra auto-fixable linter to lint-style.py and use that for the replacements instead (basically, incorporating fix-line-break.py into the other script)
    In fact, this is still possible and should in the order of 15 minutes to implement; I'll do this in my next burst of Lean time.

Given I won't outdo Mario's future auto-formatter, I'm not convinced trying to develop one myself is the right way to go.
(An auto-fixable Python style linter is fine though; did you mean this?)

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented May 31, 2024

#13419 does some more replacements, but in a fully automated way.

callesonne pushed a commit that referenced this pull request Jun 4, 2024
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants