[Merged by Bors] - feat: improve the way to_additive deals with attributes#1314
Closed
fpvandoorn wants to merge 31 commits intomasterfrom
Closed
[Merged by Bors] - feat: improve the way to_additive deals with attributes#1314fpvandoorn wants to merge 31 commits intomasterfrom
fpvandoorn wants to merge 31 commits intomasterfrom
Conversation
2 tasks
Contributor
|
@fpvandoorn, if you don't mind making the same change to |
digama0
reviewed
Jan 7, 2023
digama0
reviewed
Jan 7, 2023
digama0
reviewed
Jan 7, 2023
digama0
reviewed
Jan 8, 2023
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 9, 2023
* The new syntax for any attributes that need to be copied by `to_additive` is `@[to_additive (attrs := simp, ext, simps)]` * Adds the auxiliary declarations generated by the `simp` and `simps` attributes to the `to_additive`-dictionary. * Future issue: Does not yet translate auxiliary declarations for other attributes (including custom `simp`-attributes). In particular it's possible that `norm_cast` might generate some auxiliary declarations. * Fixes #950 * Fixes #953 * Fixes #1149 * This moves the interaction between `to_additive` and `simps` from the `Simps` file to the `toAdditive` file for uniformity. * Make the same changes to `@[reassoc]` Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
Ruben-VandeVelde
pushed a commit
that referenced
this pull request
Jan 9, 2023
jcommelin
added a commit
that referenced
this pull request
Jan 23, 2023
* The new syntax for any attributes that need to be copied by `to_additive` is `@[to_additive (attrs := simp, ext, simps)]` * Adds the auxiliary declarations generated by the `simp` and `simps` attributes to the `to_additive`-dictionary. * Future issue: Does not yet translate auxiliary declarations for other attributes (including custom `simp`-attributes). In particular it's possible that `norm_cast` might generate some auxiliary declarations. * Fixes #950 * Fixes #953 * Fixes #1149 * This moves the interaction between `to_additive` and `simps` from the `Simps` file to the `toAdditive` file for uniformity. * Make the same changes to `@[reassoc]` Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
jcommelin
pushed a commit
that referenced
this pull request
Jan 23, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_additiveis@[to_additive (attrs := simp, ext, simps)]simpandsimpsattributes to theto_additive-dictionary.simp-attributes). In particular it's possible thatnorm_castmight generate some auxiliary declarations.to_additivedoesn't interact with several other attributes. #950to_additivedoesn't copy simp priorities #953to_additiveandsimpsfrom theSimpsfile to thetoAdditivefile for uniformity.@[reassoc]