[Merged by Bors] - chore: add induction_eliminator to With{Top,Bot,Zero,One}#13096
Closed
eric-wieser wants to merge 7 commits intomasterfrom
Closed
[Merged by Bors] - chore: add induction_eliminator to With{Top,Bot,Zero,One}#13096eric-wieser wants to merge 7 commits intomasterfrom
induction_eliminator to With{Top,Bot,Zero,One}#13096eric-wieser wants to merge 7 commits intomasterfrom
Conversation
induction_eliminator to WithTop and WithBotinduction_eliminator to With{Top,Bot,Zero,One}
2 tasks
kbuzzard
approved these changes
May 21, 2024
| -- know if it does or not, and I don't know how to check, so | ||
| -- I'll add it manually just to be sure. | ||
| attribute [elab_as_elim] WithZero.recZeroCoe | ||
| attribute [elab_as_elim, induction_eliminator] WithZero.recZeroCoe |
Member
There was a problem hiding this comment.
Do you now know for sure that induction_eliminator is not being added by to_additive? If so then you could add this information to the comment above.
Member
Author
There was a problem hiding this comment.
No, this whole comment and attribute line can be removed, I just didn't want to scope creep here
Contributor
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
|
This looks like a great change to me! |
Member
|
Does it work with |
Member
Author
|
More cleanup is needed to make bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 22, 2024
This is a smaller version of #12605. This allows `using` to be dropped from `induction`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
induction_eliminator to With{Top,Bot,Zero,One}induction_eliminator to With{Top,Bot,Zero,One}
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
This is a smaller version of #12605. This allows `using` to be dropped from `induction`.
js2357
pushed a commit
that referenced
this pull request
Jun 18, 2024
This is a smaller version of #12605. This allows `using` to be dropped from `induction`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a smaller version of #12605.
This allows
usingto be dropped frominduction.