[Merged by Bors] - feat(Mathlib/Data/Fintype/Quotient): Trunc version of Quotient.finChoice#13025
Closed
[Merged by Bors] - feat(Mathlib/Data/Fintype/Quotient): Trunc version of Quotient.finChoice#13025
Trunc version of Quotient.finChoice#13025Conversation
Contributor
Komyyy
commented
May 19, 2024
1 task
Trunc version of Quotient.finChoiceTrunc version of Quotient.finChoice
1 task
eric-wieser
reviewed
May 26, 2024
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
approved these changes
May 26, 2024
Member
eric-wieser
left a comment
There was a problem hiding this comment.
bors d+
Suggestion is optional
Contributor
|
✌️ Komyyy can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 26, 2024
…Choice` (#13025) Co-authored-by: Pol'tta / Miyahara Kō <52843868+Komyyy@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Trunc version of Quotient.finChoiceTrunc version of Quotient.finChoice
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
…Choice` (#13025) Co-authored-by: Pol'tta / Miyahara Kō <52843868+Komyyy@users.noreply.github.com>
js2357
pushed a commit
that referenced
this pull request
Jun 18, 2024
…Choice` (#13025) Co-authored-by: Pol'tta / Miyahara Kō <52843868+Komyyy@users.noreply.github.com>
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jul 14, 2024
…rom some `DFinsupp` functions (#13235) This PR removes `Decidable` instances from these `DFinsupp` functions: 1. ```lean def DFinsupp.sigmaUncurry {ι : Type u} {α : ι → Type u_2} {δ : (i : ι) → α i → Type v} [(i : ι) → (j : α i) → Zero (δ i j)] [(i : ι) → DecidableEq (α i)] [(i : ι) → (j : α i) → Decidable (x ≠ 0)] (f : Π₀ (i : ι) (j : α i), δ i j) : Π₀ (i : (i : ι) × α i), δ i.fst i.snd def DFinsupp.sigmaCurryEquiv {ι : Type u} [DecidableEq ι] {α : ι → Type u_2} {δ : (i : ι) → α i → Type v} [(i : ι) → (j : α i) → Zero (δ i j)] [(i : ι) → DecidableEq (α i)] [(i : ι) → (j : α i) → Decidable (x ≠ 0)] : Π₀ (i : (i : ι) × α i), δ i.fst i.snd ≃ Π₀ (i : ι) (j : α i), δ i j ``` to ```lean def DFinsupp.sigmaUncurry {ι : Type u} {α : ι → Type u_2} {δ : (i : ι) → α i → Type v} [(i : ι) → (j : α i) → Zero (δ i j)] [DecidableEq ι] (f : Π₀ (i : ι) (j : α i), δ i j) : Π₀ (i : (i : ι) × α i), δ i.fst i.snd def DFinsupp.sigmaCurryEquiv {ι : Type u} {α : ι → Type u_2} {δ : (i : ι) → α i → Type v} [(i : ι) → (j : α i) → Zero (δ i j)] [DecidableEq ι] : Π₀ (i : (i : ι) × α i), δ i.fst i.snd ≃ Π₀ (i : ι) (j : α i), δ i j ``` We use `Trunc.finChoice` from #13025 to compute support with the only `DecidableEq ι` instance. 2. ```lean instance DFinsupp.decidableZero {ι : Type u} {β : ι → Type v} [DecidableEq ι] [(i : ι) → Zero (β i)] [(i : ι) → (x : β i) → Decidable (x ≠ 0)] (f : Π₀ (i : ι), β i) : Decidable (0 = f) ``` to ```lean instance DFinsupp.decidableZero {ι : Type u} {β : ι → Type v} [(i : ι) → Zero (β i)] [(i : ι) → (x : β i) → Decidable (x = 0)] (f : Π₀ (i : ι), β i) : Decidable (f = 0) ``` We remove the redundant `DecidableEq ι` instance. Additionally, We replace the `(i : ι) → (x : β i) → Decidable (x ≠ 0)` instance with `(i : ι) → (x : β i) → Decidable (x = 0)` because it's more principal, and swaps `f` and `0`. 3. ```lean noncomputable def DFinsupp.comapDomain {ι : Type u} {β : ι → Type v} [DecidableEq ι] {κ : Type u_1} [(i : ι) → Zero (β i)] (h : κ → ι) (hh : Function.Injective h) (f : Π₀ (i : ι), β i) : Π₀ (k : κ), β (h k) ``` to ```lean noncomputable def DFinsupp.comapDomain {ι : Type u} {β : ι → Type v} {κ : Type u_1} [(i : ι) → Zero (β i)] (h : κ → ι) (hh : Function.Injective h) (f : Π₀ (i : ι), β i) : Π₀ (k : κ), β (h k) ``` `DecidableEq ι` is required to compute unconstructive support so this is redundant. Co-authored-by: Pol'tta / Miyahara Kō <52843868+Komyyy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.