[Merged by Bors] - fix: make HeightOneSpectrum.adicCompletion an abbrev#13020
Closed
[Merged by Bors] - fix: make HeightOneSpectrum.adicCompletion an abbrev#13020
Conversation
kbuzzard
added a commit
that referenced
this pull request
May 19, 2024
2 tasks
Member
|
!bench |
Member
|
Almost sure this is harmless, but let's wait for the benching result. Thanks! bors d+ |
Contributor
|
✌️ kbuzzard can now approve this pull request. To approve and merge a pull request, simply reply with |
Collaborator
|
Here are the benchmark results for commit 38b32d6. |
Member
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 23, 2024
`IsDedekindDomain.HeightOneSpectrum.adicCompletion` is currently a `def` and this causes a bunch of `rw`s to fail in Lean 4; `erw` is needed. In developing the API further I ran into more irritating `erw` issues; changing it to an `abbrev` seems to solve them (we can get rid of several porting notes too).
Contributor
|
Pull request successfully merged into master. Build succeeded: |
grunweg
pushed a commit
that referenced
this pull request
May 24, 2024
`IsDedekindDomain.HeightOneSpectrum.adicCompletion` is currently a `def` and this causes a bunch of `rw`s to fail in Lean 4; `erw` is needed. In developing the API further I ran into more irritating `erw` issues; changing it to an `abbrev` seems to solve them (we can get rid of several porting notes too).
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
`IsDedekindDomain.HeightOneSpectrum.adicCompletion` is currently a `def` and this causes a bunch of `rw`s to fail in Lean 4; `erw` is needed. In developing the API further I ran into more irritating `erw` issues; changing it to an `abbrev` seems to solve them (we can get rid of several porting notes too).
js2357
pushed a commit
that referenced
this pull request
Jun 18, 2024
`IsDedekindDomain.HeightOneSpectrum.adicCompletion` is currently a `def` and this causes a bunch of `rw`s to fail in Lean 4; `erw` is needed. In developing the API further I ran into more irritating `erw` issues; changing it to an `abbrev` seems to solve them (we can get rid of several porting notes too).
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
#13020 turned this into an `abbrev`. The definition is kinda scary so I would argue we try to keep it behind the veil and only expose it when necessary. As a bonus, this fixes a crashing instance synthesis [Zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/adic.20completion.20is.20commutative).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsDedekindDomain.HeightOneSpectrum.adicCompletionis currently adefand this causes a bunch ofrws to fail in Lean 4;erwis needed. In developing the API further I ran into more irritatingerwissues; changing it to anabbrevseems to solve them (we can get rid of several porting notes too).Remark: this change exposed a bug in the typeclass inference system. See https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/erw.20and.20IsDedekindDomain.2EHeightOneSpectrum.2EadicCompletion/near/439391094 for more details.