[Merged by Bors] - feat(LinearAlgebra/{FiniteDimensional|Dimension/DivisionRing}): relax condition of some results#12963
Closed
[Merged by Bors] - feat(LinearAlgebra/{FiniteDimensional|Dimension/DivisionRing}): relax condition of some results#12963
Conversation
Member
|
@erdOne What do you think? Asking because IIRC you wanted to do a systematic generalization of this kind of results. Anyway this LGTM, thanks! |
Member
|
Does it make sense to move these declarations elsewhere? They're not about a division ring anymore. |
Collaborator
Author
Let me see later if they can be moved to an earlier file, e.g. |
Member
|
The stuff I put into |
Member
|
OK, good. @acmepjz do you mind moving the result in this PR? |
Collaborator
Author
It's OK for me. But I think I have to postpone this a little bit, since in fact the changes in this PR are not used in my linearly disjoint PR; only #12849 is used. I have to tackle other PRs first. It's best if someone could help me to move such contents; but if you're busy I can do it later anyway. |
Collaborator
Author
|
Done moving results to a separated file. |
|
You can run this locally as follows ## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 22, 2024
… condition of some results (#12963) ... from requiring `F` being a field to `F` satisfying `StrongRankCondition` and `S` being a free `F`-module. This makes the original statement a special case. Changed results: In `DivisionRing.lean`: - `Basis.ofRankEqZero[_apply]` - `le_rank_iff_exists_linearIndependent[_finset]` - `rank[_submodule]_le_one_iff`, `rank_submodule_le_one_iff'` - newly added result: `rank[_submodule]_eq_one_iff` - `Submodule.rank_le_one_iff_isPrincipal`, `Module.rank_le_one_iff_top_isPrincipal` In `FiniteDimensional.lean`: - `finrank_eq_one_iff`, `finrank_eq_one_iff'`, `finrank_le_one_iff` - `Submodule.finrank_le_one_iff_isPrincipal`, `Module.finrank_le_one_iff_top_isPrincipal` - `cardinal_mk_eq_cardinal_mk_field_pow_rank`, `cardinal_lt_aleph0_of_finiteDimensional` All of them are moved to a separated file.
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 22, 2024
… condition of some results (#12963) ... from requiring `F` being a field to `F` satisfying `StrongRankCondition` and `S` being a free `F`-module. This makes the original statement a special case. Changed results: In `DivisionRing.lean`: - `Basis.ofRankEqZero[_apply]` - `le_rank_iff_exists_linearIndependent[_finset]` - `rank[_submodule]_le_one_iff`, `rank_submodule_le_one_iff'` - newly added result: `rank[_submodule]_eq_one_iff` - `Submodule.rank_le_one_iff_isPrincipal`, `Module.rank_le_one_iff_top_isPrincipal` In `FiniteDimensional.lean`: - `finrank_eq_one_iff`, `finrank_eq_one_iff'`, `finrank_le_one_iff` - `Submodule.finrank_le_one_iff_isPrincipal`, `Module.finrank_le_one_iff_top_isPrincipal` - `cardinal_mk_eq_cardinal_mk_field_pow_rank`, `cardinal_lt_aleph0_of_finiteDimensional` All of them are moved to a separated file.
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 22, 2024
… condition of some results (#12963) ... from requiring `F` being a field to `F` satisfying `StrongRankCondition` and `S` being a free `F`-module. This makes the original statement a special case. Changed results: In `DivisionRing.lean`: - `Basis.ofRankEqZero[_apply]` - `le_rank_iff_exists_linearIndependent[_finset]` - `rank[_submodule]_le_one_iff`, `rank_submodule_le_one_iff'` - newly added result: `rank[_submodule]_eq_one_iff` - `Submodule.rank_le_one_iff_isPrincipal`, `Module.rank_le_one_iff_top_isPrincipal` In `FiniteDimensional.lean`: - `finrank_eq_one_iff`, `finrank_eq_one_iff'`, `finrank_le_one_iff` - `Submodule.finrank_le_one_iff_isPrincipal`, `Module.finrank_le_one_iff_top_isPrincipal` - `cardinal_mk_eq_cardinal_mk_field_pow_rank`, `cardinal_lt_aleph0_of_finiteDimensional` All of them are moved to a separated file.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
acmepjz
added a commit
that referenced
this pull request
May 22, 2024
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
… condition of some results (#12963) ... from requiring `F` being a field to `F` satisfying `StrongRankCondition` and `S` being a free `F`-module. This makes the original statement a special case. Changed results: In `DivisionRing.lean`: - `Basis.ofRankEqZero[_apply]` - `le_rank_iff_exists_linearIndependent[_finset]` - `rank[_submodule]_le_one_iff`, `rank_submodule_le_one_iff'` - newly added result: `rank[_submodule]_eq_one_iff` - `Submodule.rank_le_one_iff_isPrincipal`, `Module.rank_le_one_iff_top_isPrincipal` In `FiniteDimensional.lean`: - `finrank_eq_one_iff`, `finrank_eq_one_iff'`, `finrank_le_one_iff` - `Submodule.finrank_le_one_iff_isPrincipal`, `Module.finrank_le_one_iff_top_isPrincipal` - `cardinal_mk_eq_cardinal_mk_field_pow_rank`, `cardinal_lt_aleph0_of_finiteDimensional` All of them are moved to a separated file.
js2357
pushed a commit
that referenced
this pull request
Jun 18, 2024
… condition of some results (#12963) ... from requiring `F` being a field to `F` satisfying `StrongRankCondition` and `S` being a free `F`-module. This makes the original statement a special case. Changed results: In `DivisionRing.lean`: - `Basis.ofRankEqZero[_apply]` - `le_rank_iff_exists_linearIndependent[_finset]` - `rank[_submodule]_le_one_iff`, `rank_submodule_le_one_iff'` - newly added result: `rank[_submodule]_eq_one_iff` - `Submodule.rank_le_one_iff_isPrincipal`, `Module.rank_le_one_iff_top_isPrincipal` In `FiniteDimensional.lean`: - `finrank_eq_one_iff`, `finrank_eq_one_iff'`, `finrank_le_one_iff` - `Submodule.finrank_le_one_iff_isPrincipal`, `Module.finrank_le_one_iff_top_isPrincipal` - `cardinal_mk_eq_cardinal_mk_field_pow_rank`, `cardinal_lt_aleph0_of_finiteDimensional` All of them are moved to a separated file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... from requiring
Fbeing a field toFsatisfyingStrongRankConditionandSbeing a freeF-module. This makes the original statement a special case.Changed results:
In
DivisionRing.lean:Basis.ofRankEqZero[_apply]le_rank_iff_exists_linearIndependent[_finset]rank[_submodule]_le_one_iff,rank_submodule_le_one_iff'rank[_submodule]_eq_one_iffSubmodule.rank_le_one_iff_isPrincipal,Module.rank_le_one_iff_top_isPrincipalIn
FiniteDimensional.lean:finrank_eq_one_iff,finrank_eq_one_iff',finrank_le_one_iffSubmodule.finrank_le_one_iff_isPrincipal,Module.finrank_le_one_iff_top_isPrincipalcardinal_mk_eq_cardinal_mk_field_pow_rank,cardinal_lt_aleph0_of_finiteDimensionalAll of them are moved to a separated file.