[Merged by Bors] - feat: add a Linters file#12899
Closed
Conversation
Contributor
|
I like this idea: the specifics of how implement this seem blocked on zulip. Let me mark this PR as such. (I wonder whether importing this in |
kmill
approved these changes
May 21, 2024
Contributor
kmill
left a comment
There was a problem hiding this comment.
Just like how Tactic is singular, I think perhaps it should be Mathlib.Tactic.Linter. Other than than minor quibble, this seems like a good idea.
Contributor
|
bors d+ |
Contributor
|
✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 22, 2024
Add a new file `Mathlib.Linters` that is intended to be the entry-point for all `Mathlib` linters. This file currently contains only `Mathlib.Tactic.Lint` and is imported in `Mathlib.Common`. As linters seem to be invisible by Shake for dependencies, I also made this file invisible to Shake by marking it as * `ignoreAll`, meaning that all its imports are considered necessary; * `ignoreImport`, meaning that where it is imported, it is considered necessary. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Mathlib.2FTactic.2F*)
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 22, 2024
Add a new file `Mathlib.Linters` that is intended to be the entry-point for all `Mathlib` linters. This file currently contains only `Mathlib.Tactic.Lint` and is imported in `Mathlib.Common`. As linters seem to be invisible by Shake for dependencies, I also made this file invisible to Shake by marking it as * `ignoreAll`, meaning that all its imports are considered necessary; * `ignoreImport`, meaning that where it is imported, it is considered necessary. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Mathlib.2FTactic.2F*)
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 22, 2024
Add a new file `Mathlib.Linters` that is intended to be the entry-point for all `Mathlib` linters. This file currently contains only `Mathlib.Tactic.Lint` and is imported in `Mathlib.Common`. As linters seem to be invisible by Shake for dependencies, I also made this file invisible to Shake by marking it as * `ignoreAll`, meaning that all its imports are considered necessary; * `ignoreImport`, meaning that where it is imported, it is considered necessary. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Mathlib.2FTactic.2F*)
Contributor
|
Pull request successfully merged into master. Build succeeded: |
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
Add a new file `Mathlib.Linters` that is intended to be the entry-point for all `Mathlib` linters. This file currently contains only `Mathlib.Tactic.Lint` and is imported in `Mathlib.Common`. As linters seem to be invisible by Shake for dependencies, I also made this file invisible to Shake by marking it as * `ignoreAll`, meaning that all its imports are considered necessary; * `ignoreImport`, meaning that where it is imported, it is considered necessary. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Mathlib.2FTactic.2F*)
js2357
pushed a commit
that referenced
this pull request
Jun 18, 2024
Add a new file `Mathlib.Linters` that is intended to be the entry-point for all `Mathlib` linters. This file currently contains only `Mathlib.Tactic.Lint` and is imported in `Mathlib.Common`. As linters seem to be invisible by Shake for dependencies, I also made this file invisible to Shake by marking it as * `ignoreAll`, meaning that all its imports are considered necessary; * `ignoreImport`, meaning that where it is imported, it is considered necessary. [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Mathlib.2FTactic.2F*)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new file
Mathlib.Lintersthat is intended to be the entry-point for allMathliblinters.This file currently contains only
Mathlib.Tactic.Lintand is imported inMathlib.Common.As linters seem to be invisible by Shake for dependencies, I also made this file invisible to Shake by marking it as
ignoreAll, meaning that all its imports are considered necessary;ignoreImport, meaning that where it is imported, it is considered necessary.Zulip discussion