Skip to content

[Merged by Bors] - chore: use refine instead of refine'#12851

Closed
grunweg wants to merge 2 commits intomasterfrom
MR-more-refine
Closed

[Merged by Bors] - chore: use refine instead of refine'#12851
grunweg wants to merge 2 commits intomasterfrom
MR-more-refine

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented May 12, 2024

In three files which are modified in #12834 or #12381: in my opinion, the unprimed version makes these modifications easier to read.


Open in Gitpod

In three files which are modified in #12834 or #12381: in my opinion,
the unprimed version makes these modifications easier to read.
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 12, 2024

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels May 12, 2024
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented May 13, 2024

Thank you for the fast review.
bors r+

mathlib-bors bot pushed a commit that referenced this pull request May 13, 2024
In three files which are modified in #12834 or #12381: in my opinion, the unprimed version makes these modifications easier to read.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 13, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: use refine instead of refine' [Merged by Bors] - chore: use refine instead of refine' May 13, 2024
@mathlib-bors mathlib-bors bot closed this May 13, 2024
@mathlib-bors mathlib-bors bot deleted the MR-more-refine branch May 13, 2024 07:13
callesonne pushed a commit that referenced this pull request May 16, 2024
In three files which are modified in #12834 or #12381: in my opinion, the unprimed version makes these modifications easier to read.
grunweg added a commit that referenced this pull request May 17, 2024
In three files which are modified in #12834 or #12381: in my opinion, the unprimed version makes these modifications easier to read.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants