[Merged by Bors] - chore: Separate algebraic list lemmas#12836
Closed
YaelDillies wants to merge 10 commits intomasterfrom
Closed
[Merged by Bors] - chore: Separate algebraic list lemmas#12836YaelDillies wants to merge 10 commits intomasterfrom
YaelDillies wants to merge 10 commits intomasterfrom
Conversation
The lemmas can easily move to `Algebra.Group.Nat` and `Algebra.Group.Int`, `Algebra.Ring.Int` respectively.
Resplit `Algebra.BigOperators.List.Basic` and `Algebra.BigOperators.List.Lemmas` into two new files: * `Algebra.BigOperators.Group.List` for lemmas that require group-like structures (`Monoid`, `Group`, ...) * `Algebra.BigOperators.Ring.List` for lemmas that require ring-like structures (`MonoidWithZero`, `Ring`, ...) Add `assert_not_exists Ring` in the former. Once #11855 lands, it will be strenghtenable to `assert_not_exists MonoidWithZero`.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 task
1 task
|
This PR/issue depends on:
|
|
No declarations were harmed in the making of this PR! 🐙 You can run this locally as follows ## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Ruben-VandeVelde
approved these changes
May 16, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Member
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 16, 2024
Resplit `Algebra.BigOperators.List.Basic` and `Algebra.BigOperators.List.Lemmas` into two new files: * `Algebra.BigOperators.Group.List` for lemmas that require group-like structures (`Monoid`, `Group`, ...) * `Algebra.BigOperators.Ring.List` for lemmas that require ring-like structures (`MonoidWithZero`, `Ring`, ...) Add `assert_not_exists Ring` in the former. Once #11855 lands, it will be strenghtenable to `assert_not_exists MonoidWithZero`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
Resplit `Algebra.BigOperators.List.Basic` and `Algebra.BigOperators.List.Lemmas` into two new files: * `Algebra.BigOperators.Group.List` for lemmas that require group-like structures (`Monoid`, `Group`, ...) * `Algebra.BigOperators.Ring.List` for lemmas that require ring-like structures (`MonoidWithZero`, `Ring`, ...) Add `assert_not_exists Ring` in the former. Once #11855 lands, it will be strenghtenable to `assert_not_exists MonoidWithZero`.
grunweg
pushed a commit
that referenced
this pull request
May 17, 2024
Resplit `Algebra.BigOperators.List.Basic` and `Algebra.BigOperators.List.Lemmas` into two new files: * `Algebra.BigOperators.Group.List` for lemmas that require group-like structures (`Monoid`, `Group`, ...) * `Algebra.BigOperators.Ring.List` for lemmas that require ring-like structures (`MonoidWithZero`, `Ring`, ...) Add `assert_not_exists Ring` in the former. Once #11855 lands, it will be strenghtenable to `assert_not_exists MonoidWithZero`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resplit
Algebra.BigOperators.List.BasicandAlgebra.BigOperators.List.Lemmasinto two new files:Algebra.BigOperators.Group.Listfor lemmas that require group-like structures (Monoid,Group, ...)Algebra.BigOperators.Ring.Listfor lemmas that require ring-like structures (MonoidWithZero,Ring, ...)Add
assert_not_exists Ringin the former. Once #11855 lands, it will be strenghtenable toassert_not_exists MonoidWithZero.Data.Nat.Units,Data.Int.Units#12835