[Merged by Bors] - feat(Mathlib/Order/Ideal): ideals of sets are stable under directed unions and chains#12651
Closed
[Merged by Bors] - feat(Mathlib/Order/Ideal): ideals of sets are stable under directed unions and chains#12651
Conversation
Ruben-VandeVelde
requested changes
May 4, 2024
Contributor
|
And I should say: thanks for the contribution! |
Contributor
Author
|
Thanks very much for the help @Ruben-VandeVelde and @dagurtomas! I implemented your comments just now. I also did "Resolve conversation" for each comment and changed back to "awaiting-review". I hope this is the correct workflow? |
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
Yes, that's the correct workflow. Thanks!
Contributor
Author
|
I just added the deprecation notice as per @Ruben-VandeVelde 's suggestion. |
1 task
Ruben-VandeVelde
approved these changes
May 7, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 7, 2024
…nions and chains (#12651) We prove that the directed union of a non-empty directed union of ideals of subsets of a preorder is an ideal, and in particular ideals of subsets of a preorder are stable under unions. In order to prove it, we also add `directed_on_sUnion`, a variant of `directed_on_iUnion`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
…nions and chains (#12651) We prove that the directed union of a non-empty directed union of ideals of subsets of a preorder is an ideal, and in particular ideals of subsets of a preorder are stable under unions. In order to prove it, we also add `directed_on_sUnion`, a variant of `directed_on_iUnion`.
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
…nions and chains (#12651) We prove that the directed union of a non-empty directed union of ideals of subsets of a preorder is an ideal, and in particular ideals of subsets of a preorder are stable under unions. In order to prove it, we also add `directed_on_sUnion`, a variant of `directed_on_iUnion`.
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 16, 2024
…d distributive lattice (#12705) We prove that a disjoint filter and ideal in a bounded distributive lattice can always be separated by a prime ideal. This is a step towards establishing Stone duality (currently in development here: https://github.com/samvang/StoneDualityInLean/) - [x] depends on: #12651 (ideals of sets are stable under directed unions and chains)
grunweg
pushed a commit
that referenced
this pull request
May 17, 2024
…d distributive lattice (#12705) We prove that a disjoint filter and ideal in a bounded distributive lattice can always be separated by a prime ideal. This is a step towards establishing Stone duality (currently in development here: https://github.com/samvang/StoneDualityInLean/) - [x] depends on: #12651 (ideals of sets are stable under directed unions and chains)
callesonne
pushed a commit
that referenced
this pull request
Jun 4, 2024
…d distributive lattice (#12705) We prove that a disjoint filter and ideal in a bounded distributive lattice can always be separated by a prime ideal. This is a step towards establishing Stone duality (currently in development here: https://github.com/samvang/StoneDualityInLean/) - [x] depends on: #12651 (ideals of sets are stable under directed unions and chains)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We prove that the directed union of a non-empty directed union of ideals of subsets of a preorder is an ideal, and in particular ideals of subsets of a preorder are stable under unions. In order to prove it, we also add
directed_on_sUnion, a variant ofdirected_on_iUnion.