[Merged by Bors] - feat: IsHomeomorph predicate#12533
[Merged by Bors] - feat: IsHomeomorph predicate#12533peabrainiac wants to merge 4 commits intomasterfrom
IsHomeomorph predicate#12533Conversation
|
Thanks for your contribution! Is this ready for review? If so, please label it |
|
For context, there was already a little bit of discussion over this here on Zulip. One concern voiced there was that having an unbundled predicate in addition to the bundled |
|
Hi @peabrainiac, this PR looks mostly fine, but there are still some places where it needs some work. Are you planning to continue working on this PR? Would you like some help from others, or do you want to hand over completely? (In the latter case, please label it with |
|
@peabrainiac, it looks like the PR hasn't moved since we last pinged you. We're going to close this for now, just for the sake of cleaning up our PR queue. But please do feel free to either re-open the PR if you'd like to continue working on it, or come across to the PR reviews zulip stream to ask for advice or request that we look at this again. |
|
@j-loreaux asked that we reopen this. |
216b0a9 to
96d4dd2
Compare
PR summary 80789fee7fImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
j-loreaux
left a comment
There was a problem hiding this comment.
Thanks for adopting this Yaël!
|
build failing @YaelDillies bors d+ |
|
✌️ peabrainiac can now approve this pull request. To approve and merge a pull request, simply reply with |
|
oops bors d=yaeldillies |
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors d- |
|
bors merge |
Define an `IsHomeomorph` predicate for maps between topological spaces to complement the existing bundled `Homeomorph` API. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
IsHomeomorph predicateIsHomeomorph predicate
Define an `IsHomeomorph` predicate for maps between topological spaces to complement the existing bundled `Homeomorph` API. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Define an `IsHomeomorph` predicate for maps between topological spaces to complement the existing bundled `Homeomorph` API. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Define an `IsHomeomorph` predicate for maps between topological spaces to complement the existing bundled `Homeomorph` API. Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Define an
IsHomeomorphpredicate for maps between topological spaces to complement the existing bundledHomeomorphAPI.