Skip to content

[Merged by Bors] - feat: IsHomeomorph predicate#12533

Closed
peabrainiac wants to merge 4 commits intomasterfrom
isHomeomorph
Closed

[Merged by Bors] - feat: IsHomeomorph predicate#12533
peabrainiac wants to merge 4 commits intomasterfrom
isHomeomorph

Conversation

@peabrainiac
Copy link
Copy Markdown
Collaborator

@peabrainiac peabrainiac commented Apr 30, 2024

Define an IsHomeomorph predicate for maps between topological spaces to complement the existing bundled Homeomorph API.


Open in Gitpod

@peabrainiac peabrainiac added t-topology Topological spaces, uniform spaces, metric spaces, filters new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! labels Apr 30, 2024
@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Apr 30, 2024

Thanks for your contribution! Is this ready for review? If so, please label it awaiting-review. (See here for a more detailed explanation of this and related labels.)

@peabrainiac
Copy link
Copy Markdown
Collaborator Author

For context, there was already a little bit of discussion over this here on Zulip. One concern voiced there was that having an unbundled predicate in addition to the bundled Homeomorph structure would encourage a lot of API duplication. The way I've tried to avoid that is by only implementing API relating this to other unbundled properties of maps, such as with IsHomeomorph.isClosedMap - theorems involving properties of sets and spaces, like Homeomorph.compactSpace, are still available only for bundled homeomorphisms. My hope is that this provides enough API for most situations in which the IsHomeomorph predicate might be used, while also making it easy enough to convert between the IsHomeomorph and Homeomorph types when the additional API of Homeomorph is needed.

@YaelDillies YaelDillies added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Jun 6, 2024
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 19, 2024
@jcommelin
Copy link
Copy Markdown
Member

Hi @peabrainiac, this PR looks mostly fine, but there are still some places where it needs some work. Are you planning to continue working on this PR? Would you like some help from others, or do you want to hand over completely? (In the latter case, please label it with please-adopt.)

@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Aug 19, 2024

@peabrainiac, it looks like the PR hasn't moved since we last pinged you. We're going to close this for now, just for the sake of cleaning up our PR queue. But please do feel free to either re-open the PR if you'd like to continue working on it, or come across to the PR reviews zulip stream to ask for advice or request that we look at this again.

@kim-em kim-em closed this Aug 19, 2024
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Aug 20, 2024

@j-loreaux asked that we reopen this.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 20, 2024

PR summary 80789fee7f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Homeomorph.isHomeomorph
+ IsHomeomorph
+ IsHomeomorph.comp
+ IsHomeomorph.id
+ IsHomeomorph.isProperMap
+ IsHomeomorph.pi_map
+ IsHomeomorph.prodMap
+ IsHomeomorph.sigmaMap
+ IsHomeomorph.sumMap
+ IsOpenMap.sumMap
+ closedEmbedding
+ denseEmbedding
+ embedding
+ homeomorph
+ inducing
+ injective
+ isClosedMap
+ isHomeomorph_iff_continuous_bijective
+ isHomeomorph_iff_continuous_isClosedMap_bijective
+ isHomeomorph_iff_embedding_surjective
+ isHomeomorph_iff_exists_homeomorph
+ isHomeomorph_iff_exists_inverse
+ openEmbedding
+ quotientMap
+ surjective

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 20, 2024
Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adopting this Yaël!

@j-loreaux
Copy link
Copy Markdown
Contributor

build failing @YaelDillies

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 22, 2024

✌️ peabrainiac can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Aug 22, 2024
@j-loreaux
Copy link
Copy Markdown
Contributor

oops

bors d=yaeldillies

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 22, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@j-loreaux
Copy link
Copy Markdown
Contributor

bors d-

@YaelDillies YaelDillies removed the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 23, 2024
@YaelDillies
Copy link
Copy Markdown
Contributor

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Aug 23, 2024
Define an `IsHomeomorph` predicate for maps between topological spaces to complement the existing bundled `Homeomorph` API.



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Aug 23, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: IsHomeomorph predicate [Merged by Bors] - feat: IsHomeomorph predicate Aug 23, 2024
@mathlib-bors mathlib-bors bot closed this Aug 23, 2024
@mathlib-bors mathlib-bors bot deleted the isHomeomorph branch August 23, 2024 11:17
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
Define an `IsHomeomorph` predicate for maps between topological spaces to complement the existing bundled `Homeomorph` API.



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
Define an `IsHomeomorph` predicate for maps between topological spaces to complement the existing bundled `Homeomorph` API.



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 12, 2024
Define an `IsHomeomorph` predicate for maps between topological spaces to complement the existing bundled `Homeomorph` API.



Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants