Skip to content

[Merged by Bors] - chore: move summable lemmas#12503

Closed
CBirkbeck wants to merge 9 commits intomasterfrom
move_summable_lemmas
Closed

[Merged by Bors] - chore: move summable lemmas#12503
CBirkbeck wants to merge 9 commits intomasterfrom
move_summable_lemmas

Conversation

@CBirkbeck
Copy link
Copy Markdown
Collaborator

@CBirkbeck CBirkbeck commented Apr 29, 2024

We move some lemmas out of Topology/Instances/ENNReal into Topology/Algebra/InfiniteSum/Real. Also use this to address a porting TODO.

This was originally part of #12446


Open in Gitpod

@CBirkbeck CBirkbeck marked this pull request as ready for review April 29, 2024 08:41
@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Apr 29, 2024
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thanks for splitting these out!

@Ruben-VandeVelde Ruben-VandeVelde changed the title Move summable lemmas chore: move summable lemmas Apr 29, 2024
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems okay, though I don't know which direction of dependency is best between these two files.

@adomani
Copy link
Copy Markdown
Contributor

adomani commented Apr 29, 2024

The no_lost_declarations script reports


  • 0 added declarations
  • 0 removed declarations
  • 9 paired declarations

🎉

@CBirkbeck
Copy link
Copy Markdown
Collaborator Author

So is this ready to go?

@CBirkbeck CBirkbeck removed the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Apr 30, 2024
@loefflerd
Copy link
Copy Markdown
Contributor

LGTM

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by loefflerd.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 30, 2024
@sgouezel
Copy link
Copy Markdown
Contributor

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Apr 30, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 30, 2024
We move some lemmas out of `Topology/Instances/ENNReal` into `Topology/Algebra/InfiniteSum/Real`. Also use this to address a porting TODO.

This was originally part of #12446 



Co-authored-by: Chris Birkbeck <c.birkbeck@uea.ac.uk>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 30, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: move summable lemmas [Merged by Bors] - chore: move summable lemmas Apr 30, 2024
@mathlib-bors mathlib-bors bot closed this Apr 30, 2024
@mathlib-bors mathlib-bors bot deleted the move_summable_lemmas branch April 30, 2024 16:16
apnelson1 pushed a commit that referenced this pull request May 12, 2024
We move some lemmas out of `Topology/Instances/ENNReal` into `Topology/Algebra/InfiniteSum/Real`. Also use this to address a porting TODO.

This was originally part of #12446 



Co-authored-by: Chris Birkbeck <c.birkbeck@uea.ac.uk>
callesonne pushed a commit that referenced this pull request May 16, 2024
We move some lemmas out of `Topology/Instances/ENNReal` into `Topology/Algebra/InfiniteSum/Real`. Also use this to address a porting TODO.

This was originally part of #12446 



Co-authored-by: Chris Birkbeck <c.birkbeck@uea.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants