[Merged by Bors] - feat(Complex/UpperHalfPlane): add vertical strips#12443
Closed
[Merged by Bors] - feat(Complex/UpperHalfPlane): add vertical strips#12443
Conversation
…s and make i as an element of the upper half plane
5 tasks
Contributor
|
Since the vertical-strip stuff doesn't use the metric any more, it probably shouldn't be in |
Collaborator
Author
Good point, I'm not quite sure where to place it, I guess it could go into topology? |
grunweg
approved these changes
Apr 26, 2024
Contributor
grunweg
left a comment
There was a problem hiding this comment.
Looks straightforward; I just have three minor comments. Thanks for your contribution!
grunweg
reviewed
Apr 26, 2024
Contributor
|
I think for consistency with mathlib's naming conventions, |
loefflerd
approved these changes
Apr 30, 2024
Contributor
loefflerd
left a comment
There was a problem hiding this comment.
LGTM, thanks!
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by loefflerd. |
Member
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
We define the vertical strips that are needed for proving Eisenstein series are modular forms #10377 . We also add the definition of sqrt{-1} as an elements of the upper half plane. Note that this is no longer needed for the modular forms PRs but its good to have. Sorry about the typo in the PR name, its not my day! Co-authored-by: Chris Birkbeck <c.birkbeck@uea.ac.uk>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
apnelson1
pushed a commit
that referenced
this pull request
May 12, 2024
We define the vertical strips that are needed for proving Eisenstein series are modular forms #10377 . We also add the definition of sqrt{-1} as an elements of the upper half plane. Note that this is no longer needed for the modular forms PRs but its good to have. Sorry about the typo in the PR name, its not my day! Co-authored-by: Chris Birkbeck <c.birkbeck@uea.ac.uk>
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
We define the vertical strips that are needed for proving Eisenstein series are modular forms #10377 . We also add the definition of sqrt{-1} as an elements of the upper half plane. Note that this is no longer needed for the modular forms PRs but its good to have. Sorry about the typo in the PR name, its not my day! Co-authored-by: Chris Birkbeck <c.birkbeck@uea.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We define the vertical strips that are needed for proving Eisenstein series are modular forms #10377 . We also add the definition of sqrt{-1} as an elements of the upper half plane. Note that this is no longer needed for the modular forms PRs but its good to have.
Sorry about the typo in the PR name, its not my day!