Skip to content

[Merged by Bors] - chore: remove unnecessary cdots#12417

Closed
adomani wants to merge 1 commit intomasterfrom
adomani/some_uncdots
Closed

[Merged by Bors] - chore: remove unnecessary cdots#12417
adomani wants to merge 1 commit intomasterfrom
adomani/some_uncdots

Conversation

@adomani
Copy link
Copy Markdown
Contributor

@adomani adomani commented Apr 25, 2024

These · are scoping when there is a single active goal.

These were found using a modification of the linter at #12339.


Open in Gitpod

Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! The code changes look good to me; I trust you/the linter that all these instances actually have only a single goal active.

apply add_lt_add
exact Nat.mul_self_lt_mul_self h
apply Nat.add_lt_add_right; assumption
· exact Nat.mul_self_lt_mul_self h
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is adding cdots (but looks like a good change regardless).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right: I messed up with git and pulled in a change from the other PR that was adding the cdots.

noncomputable instance _root_.Function.Embedding.fintype {α β} [Fintype α] [Fintype β] :
Fintype (α ↪ β) :=
by classical. exact Fintype.ofEquiv _ (Equiv.subtypeInjectiveEquivEmbedding α β)
by classical exact Fintype.ofEquiv _ (Equiv.subtypeInjectiveEquivEmbedding α β)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice "c"dot :-)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a plus of looking at the SyntaxNodeKind, rather than what the user actually typed...

@fpvandoorn
Copy link
Copy Markdown
Member

Thanks!

bors merge
bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 26, 2024

✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Apr 26, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 26, 2024
These `·` are scoping when there is a single active goal.

These were found using a modification of the linter at #12339.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 26, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove unnecessary cdots [Merged by Bors] - chore: remove unnecessary cdots Apr 26, 2024
@mathlib-bors mathlib-bors bot closed this Apr 26, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/some_uncdots branch April 26, 2024 16:16
apnelson1 pushed a commit that referenced this pull request May 12, 2024
These `·` are scoping when there is a single active goal.

These were found using a modification of the linter at #12339.
callesonne pushed a commit that referenced this pull request May 16, 2024
These `·` are scoping when there is a single active goal.

These were found using a modification of the linter at #12339.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants