[Merged by Bors] - chore: Final cleanup before NNRat.cast#12360
Closed
YaelDillies wants to merge 5 commits intomasterfrom
Closed
[Merged by Bors] - chore: Final cleanup before NNRat.cast#12360YaelDillies wants to merge 5 commits intomasterfrom
NNRat.cast#12360YaelDillies wants to merge 5 commits intomasterfrom
Conversation
This is the parts of the diff of #11203 which don't mention `NNRat.cast`. * Use more `where` notation. * Write `qsmul := _` instead of `qsmul := qsmulRec _`. * Move `qsmul` before `ratCast_def` in instance declarations. * Name more instances. * Rename `rat_smul` to `qsmul`. *
eric-wieser
reviewed
Apr 23, 2024
12 tasks
Member
|
bors d+ Thanks! |
Contributor
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors merge |
eric-wieser
reviewed
Apr 23, 2024
Contributor
|
Canceled. |
Contributor
Author
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
This is the parts of the diff of #11203 which don't mention `NNRat.cast`. * Use more `where` notation. * Write `qsmul := _` instead of `qsmul := qsmulRec _` to make the instances more robust to definition changes. * Delete `qsmulRec`. * Move `qsmul` before `ratCast_def` in instance declarations. * Name more instances. * Rename `rat_smul` to `qsmul`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
NNRat.castNNRat.cast
Jun2M
pushed a commit
that referenced
this pull request
Apr 24, 2024
This is the parts of the diff of #11203 which don't mention `NNRat.cast`. * Use more `where` notation. * Write `qsmul := _` instead of `qsmul := qsmulRec _` to make the instances more robust to definition changes. * Delete `qsmulRec`. * Move `qsmul` before `ratCast_def` in instance declarations. * Name more instances. * Rename `rat_smul` to `qsmul`.
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
This is the parts of the diff of #11203 which don't mention `NNRat.cast`. * Use more `where` notation. * Write `qsmul := _` instead of `qsmul := qsmulRec _` to make the instances more robust to definition changes. * Delete `qsmulRec`. * Move `qsmul` before `ratCast_def` in instance declarations. * Name more instances. * Rename `rat_smul` to `qsmul`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the parts of the diff of #11203 which don't mention
NNRat.cast.wherenotation.qsmul := _instead ofqsmul := qsmulRec _to make the instances more robust to definition changes.qsmulRec.qsmulbeforeratCast_defin instance declarations.rat_smultoqsmul.