Skip to content

[Merged by Bors] - feat: Generalise sign of power lemmas#12289

Closed
Ruben-VandeVelde wants to merge 3 commits intomasterfrom
sign-power
Closed

[Merged by Bors] - feat: Generalise sign of power lemmas#12289
Ruben-VandeVelde wants to merge 3 commits intomasterfrom
sign-power

Conversation

@Ruben-VandeVelde
Copy link
Copy Markdown
Contributor

@Ruben-VandeVelde Ruben-VandeVelde commented Apr 20, 2024


From #11986.

Open in Gitpod

section Powers

set_option linter.deprecated false
section LinearOrderedSemiring_ExistsAddOfLE
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YaelDillies, can you add a comment to this section explaining why this is more interesting than CanonicallyOrderedCommSemiring?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean CanonicallyLinearOrderedCommSemiring (which doesn't exist)?

Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d=@YaelDillies

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 20, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Apr 20, 2024
@YaelDillies
Copy link
Copy Markdown
Contributor

bors merge

@YaelDillies YaelDillies changed the title feat: generalise sign of power lemmas feat: Generalise sign of power lemmas Apr 20, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 20, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 20, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Generalise sign of power lemmas [Merged by Bors] - feat: Generalise sign of power lemmas Apr 20, 2024
@mathlib-bors mathlib-bors bot closed this Apr 20, 2024
@mathlib-bors mathlib-bors bot deleted the sign-power branch April 20, 2024 18:50
Jun2M pushed a commit that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants