Skip to content

[Merged by Bors] - chore: backports from #11997, adaptations for nightly-2024-04-07#12176

Closed
kim-em wants to merge 17 commits intomasterfrom
backports_from_11997
Closed

[Merged by Bors] - chore: backports from #11997, adaptations for nightly-2024-04-07#12176
kim-em wants to merge 17 commits intomasterfrom
backports_from_11997

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Apr 16, 2024

These are changes from #11997, the latest adaptation PR for nightly-2024-04-07, which can be made directly on master.

Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're reverting a few changes from master. As it seems other people are also reviewing this, let me stop here :-)

@TwoFX TwoFX added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Apr 16, 2024
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, with my three remaining comments addressed, the diff looks plausible to me.

@TwoFX TwoFX added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Apr 16, 2024
Copy link
Copy Markdown
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 16, 2024

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Apr 16, 2024
@TwoFX
Copy link
Copy Markdown
Member

TwoFX commented Apr 16, 2024

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Apr 16, 2024
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 16, 2024

Canceled.

@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Apr 16, 2024

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Apr 16, 2024
)

These are changes from #11997, the latest adaptation PR for nightly-2024-04-07, which can be made directly on master.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: backports from #11997, adaptations for nightly-2024-04-07 [Merged by Bors] - chore: backports from #11997, adaptations for nightly-2024-04-07 Apr 16, 2024
@mathlib-bors mathlib-bors bot closed this Apr 16, 2024
@mathlib-bors mathlib-bors bot deleted the backports_from_11997 branch April 16, 2024 12:42
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
)

These are changes from #11997, the latest adaptation PR for nightly-2024-04-07, which can be made directly on master.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
kim-em added a commit that referenced this pull request Apr 17, 2024
)

These are changes from #11997, the latest adaptation PR for nightly-2024-04-07, which can be made directly on master.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
)

These are changes from #11997, the latest adaptation PR for nightly-2024-04-07, which can be made directly on master.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
callesonne pushed a commit that referenced this pull request Apr 22, 2024
)

These are changes from #11997, the latest adaptation PR for nightly-2024-04-07, which can be made directly on master.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Jun2M pushed a commit that referenced this pull request Apr 24, 2024
)

These are changes from #11997, the latest adaptation PR for nightly-2024-04-07, which can be made directly on master.

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants