[Merged by Bors] - chore(Logic): reduce use of autoImplicit#12135
Closed
[Merged by Bors] - chore(Logic): reduce use of autoImplicit#12135
Conversation
In some files, just marked the few declarations still using it: this should be cleaned up (but can happen later). Delete one unused variable in Logic/Basic.
kim-em
reviewed
Apr 18, 2024
kim-em
reviewed
Apr 18, 2024
Contributor
|
I'm a bit skeptical of replacing bors d+ |
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Remove one unused variable f:\alpha\to\beta.
Contributor
Author
|
@semorrison Thanks for the review; I have fixed your nits. |
Contributor
Author
|
Since I have not further comments, let me |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
In one case, replacing this naively errored, so I just merged the single declaration using it. Delete two unused variables in Logic/Basic.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
In one case, replacing this naively errored, so I just merged the single declaration using it. Delete two unused variables in Logic/Basic.
Jun2M
pushed a commit
that referenced
this pull request
Apr 24, 2024
In one case, replacing this naively errored, so I just merged the single declaration using it. Delete two unused variables in Logic/Basic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In one case, replacing this naively errored, so I just merged the single declaration using it.
Delete two unused variables in Logic/Basic.
Commits can be reviewed individually.