[Merged by Bors] - fix: make sure tactics in DefEqTransformations do not reorder hypotheses#12077
Closed
[Merged by Bors] - fix: make sure tactics in DefEqTransformations do not reorder hypotheses#12077
Conversation
adomani
approved these changes
Apr 12, 2024
Contributor
There was a problem hiding this comment.
Thank you very much Kyle, this looks great!
I do not understand the tiny details of the changes, but it all looks very good! I checked that the new unfold_let is idempotent in all the test files and a few other random locations and it seems to be!
kmill
commented
Apr 12, 2024
Comment on lines
+26
to
+30
| let lctx := (← mvarId.getDecl).lctx | ||
| let some decl := lctx.find? fvarId | throwTacticEx `changeLocalDecl mvarId m!"\ | ||
| local variable {Expr.fvar fvarId} is not present in local context{mvarId}" | ||
| let toRevert := lctx.foldl (init := #[]) fun arr decl' => | ||
| if decl.index ≤ decl'.index then arr.push decl'.fvarId else arr |
Contributor
Author
There was a problem hiding this comment.
@adomani If you want to be more comfortable reviewing, here's what to look for: the last five lines are new, creating this toRevert array.
The change to runDefEqTactic seems straightforward.
Contributor
There was a problem hiding this comment.
Ok, I had indeed "micro-diffed" your PR, but thanks for the encouragement!
I'll be more assertive:
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by adomani. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
…ses (#12077) Reported by Damiano Testa [on Zulip](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/.60unfold_let.60.20weirdness/near/432757494). The upstream function `Lean.MVarId.changeLocalDecl` should probably be changed to preserve hypothesis order, but for now we add the `Lean.MVarId.changeLocalDecl'` variant.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
…ses (#12077) Reported by Damiano Testa [on Zulip](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/.60unfold_let.60.20weirdness/near/432757494). The upstream function `Lean.MVarId.changeLocalDecl` should probably be changed to preserve hypothesis order, but for now we add the `Lean.MVarId.changeLocalDecl'` variant.
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
…ses (#12077) Reported by Damiano Testa [on Zulip](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/.60unfold_let.60.20weirdness/near/432757494). The upstream function `Lean.MVarId.changeLocalDecl` should probably be changed to preserve hypothesis order, but for now we add the `Lean.MVarId.changeLocalDecl'` variant.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
…ses (#12077) Reported by Damiano Testa [on Zulip](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/.60unfold_let.60.20weirdness/near/432757494). The upstream function `Lean.MVarId.changeLocalDecl` should probably be changed to preserve hypothesis order, but for now we add the `Lean.MVarId.changeLocalDecl'` variant.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
…ses (#12077) Reported by Damiano Testa [on Zulip](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/.60unfold_let.60.20weirdness/near/432757494). The upstream function `Lean.MVarId.changeLocalDecl` should probably be changed to preserve hypothesis order, but for now we add the `Lean.MVarId.changeLocalDecl'` variant.
Jun2M
pushed a commit
that referenced
this pull request
Apr 24, 2024
…ses (#12077) Reported by Damiano Testa [on Zulip](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/.60unfold_let.60.20weirdness/near/432757494). The upstream function `Lean.MVarId.changeLocalDecl` should probably be changed to preserve hypothesis order, but for now we add the `Lean.MVarId.changeLocalDecl'` variant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by Damiano Testa on Zulip.
The upstream function
Lean.MVarId.changeLocalDeclshould probably be changed to preserve hypothesis order, but for now we add theLean.MVarId.changeLocalDecl'variant.