Skip to content

[Merged by Bors] - feat: add Subalgebra.finite_(bot|sup)#12025

Closed
acmepjz wants to merge 3 commits intomasterfrom
acmepjz_finite_bot_and_sup
Closed

[Merged by Bors] - feat: add Subalgebra.finite_(bot|sup)#12025
acmepjz wants to merge 3 commits intomasterfrom
acmepjz_finite_bot_and_sup

Conversation

@acmepjz
Copy link
Copy Markdown
Collaborator

@acmepjz acmepjz commented Apr 8, 2024

... and deprecated Subalgebra.finiteDimensional_(bot|sup)


Open in Gitpod

@acmepjz acmepjz added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) labels Apr 8, 2024
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Apr 9, 2024
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 11, 2024

✌️ acmepjz can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Apr 11, 2024
@eric-wieser
Copy link
Copy Markdown
Member

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Apr 11, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 11, 2024
... and deprecated `Subalgebra.finiteDimensional_(bot|sup)`
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 11, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add Subalgebra.finite_(bot|sup) [Merged by Bors] - feat: add Subalgebra.finite_(bot|sup) Apr 11, 2024
@mathlib-bors mathlib-bors bot closed this Apr 11, 2024
@mathlib-bors mathlib-bors bot deleted the acmepjz_finite_bot_and_sup branch April 11, 2024 19:59
xgenereux pushed a commit that referenced this pull request Apr 15, 2024
... and deprecated `Subalgebra.finiteDimensional_(bot|sup)`
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
... and deprecated `Subalgebra.finiteDimensional_(bot|sup)`
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
... and deprecated `Subalgebra.finiteDimensional_(bot|sup)`
callesonne pushed a commit that referenced this pull request Apr 22, 2024
... and deprecated `Subalgebra.finiteDimensional_(bot|sup)`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants