[Merged by Bors] - chore: remove unused @[simp] from Fin.sub_one_lt_iff#11967
Closed
[Merged by Bors] - chore: remove unused @[simp] from Fin.sub_one_lt_iff#11967
Conversation
Member
|
Can you explain in the description why this lemma is bad? |
Member
|
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
The @[simp] annotation is not used in mathlib, and triggered a linter failure that I don't care to investigate unnecessarily. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Member
|
This lemma holds for |
Member
|
I think so! |
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
The @[simp] annotation is not used in mathlib, and triggered a linter failure that I don't care to investigate unnecessarily. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
kim-em
added a commit
that referenced
this pull request
Apr 18, 2024
The @[simp] annotation is not used in mathlib, and triggered a linter failure that I don't care to investigate unnecessarily. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
The @[simp] annotation is not used in mathlib, and triggered a linter failure that I don't care to investigate unnecessarily. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
The @[simp] annotation is not used in mathlib, and triggered a linter failure that I don't care to investigate unnecessarily. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Jun2M
pushed a commit
that referenced
this pull request
Apr 24, 2024
The @[simp] annotation is not used in mathlib, and triggered a linter failure that I don't care to investigate unnecessarily. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The @[simp] annotation is not used in mathlib, and triggered a linter failure that I don't care to investigate unnecessarily.