[Merged by Bors] - feat: port cc tactic (1/3)#11956
Closed
Conversation
Contributor
Author
|
My English in the documents is possibly poor, please correct. |
1 task
This was referenced Apr 6, 2024
Vierkantor
reviewed
Apr 11, 2024
Contributor
Vierkantor
left a comment
There was a problem hiding this comment.
Overall this looks good, thanks for the hard work in porting! I think it's important to get this documented well while you still understand how the CC tactic works. Otherwise I have minor changes.
Vierkantor
reviewed
Apr 18, 2024
Contributor
Vierkantor
left a comment
There was a problem hiding this comment.
I think I understand now what each of the datastructures is intended to do, and I have written some documentation strings. Could you please check that my suggestions are correct? If you agree with a suggested docstring, please apply it. Otherwise, could you try to write a correct docstring?
Contributor
|
I think this is ready to get merged with a few last tweaks. Thanks! bors d+ |
Contributor
|
✌️ Komyyy can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
In this PR, we implements datatypes which is used in `cc` tactic. Also, `Init.CCLemmas` is removed in #10696, but this module is required for `cc` tactic, so we recover this module as `Tactic.CC.Lemmas`.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
cc tactic (1/3)cc tactic (1/3)
Jun2M
pushed a commit
that referenced
this pull request
Apr 24, 2024
In this PR, we implements datatypes which is used in `cc` tactic. Also, `Init.CCLemmas` is removed in #10696, but this module is required for `cc` tactic, so we recover this module as `Tactic.CC.Lemmas`.
callesonne
pushed a commit
that referenced
this pull request
May 16, 2024
In this PR, we implements datatypes which is used in `cc` tactic. Also, `Init.CCLemmas` is removed in #10696, but this module is required for `cc` tactic, so we recover this module as `Tactic.CC.Lemmas`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we implements datatypes which is used in
cctactic.Also,
Init.CCLemmasis removed in #10696, but this module is required forcctactic, so we recover this module asTactic.CC.Lemmas.