Skip to content

[Merged by Bors] - chore: remove mathport name: <expression> lines#11928

Closed
grunweg wants to merge 2 commits intomasterfrom
MR-remove-mathport2
Closed

[Merged by Bors] - chore: remove mathport name: <expression> lines#11928
grunweg wants to merge 2 commits intomasterfrom
MR-remove-mathport2

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Apr 5, 2024

Quoting @digama0:

These were actually never meant to go in the file, they are basically debugging information and only useful on significantly broken mathport files. You can safely remove all of them.


Labelling as "easy" because the diff is purely mechanical.

Open in Gitpod

@grunweg grunweg added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. labels Apr 5, 2024
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 5, 2024
@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Apr 5, 2024
Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2024

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 6, 2024
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Apr 6, 2024

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Apr 6, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 6, 2024
[Quoting](#11905 (comment)) `@digama0`:
> These were actually never meant to go in the file, they are basically debugging information and only useful on significantly broken mathport files. You can safely remove all of them.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 6, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove mathport name: <expression> lines [Merged by Bors] - chore: remove mathport name: <expression> lines Apr 6, 2024
@mathlib-bors mathlib-bors bot closed this Apr 6, 2024
@mathlib-bors mathlib-bors bot deleted the MR-remove-mathport2 branch April 6, 2024 08:38
xgenereux pushed a commit that referenced this pull request Apr 15, 2024
[Quoting](#11905 (comment)) `@digama0`:
> These were actually never meant to go in the file, they are basically debugging information and only useful on significantly broken mathport files. You can safely remove all of them.
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
[Quoting](#11905 (comment)) `@digama0`:
> These were actually never meant to go in the file, they are basically debugging information and only useful on significantly broken mathport files. You can safely remove all of them.
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
[Quoting](#11905 (comment)) `@digama0`:
> These were actually never meant to go in the file, they are basically debugging information and only useful on significantly broken mathport files. You can safely remove all of them.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
[Quoting](#11905 (comment)) `@digama0`:
> These were actually never meant to go in the file, they are basically debugging information and only useful on significantly broken mathport files. You can safely remove all of them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants