[Merged by Bors] - chore(Data/List): Do not depend on algebra#11845
Closed
YaelDillies wants to merge 6 commits intomasterfrom
Closed
[Merged by Bors] - chore(Data/List): Do not depend on algebra#11845YaelDillies wants to merge 6 commits intomasterfrom
YaelDillies wants to merge 6 commits intomasterfrom
Conversation
Remove dependencies on algebra in the `Data.List` folder except for: * `Data.List.EditDistance`: Actually relies on algebra. Maybe should be moved? * `Data.List.Card`: Completely unused and redundant. * `Data.List.Cycle`: Relies on `Fintype`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.Func`: Completely unused and redundant. * `Data.List.Lex`: That's order theory. Could be moved. * `Data.List.Prime`. That's algebra. Should definitely be moved. * `Data.List.Sym`: Relies on `Multiset`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.ToFinsupp`: That's algebra. Should definitely be moved. As a consequence, move the big operators lemmas that were in there to `Algebra.BigOperators.List.Basic`. For the lemmas that were `Nat`-specific and not about auxiliary definitions, keep a version of them in the original file but stated using `Nat.sum`.
Ruben-VandeVelde
approved these changes
Apr 5, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Contributor
|
bors r+ |
Contributor
|
Merge conflict. |
16 tasks
Contributor
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 6, 2024
Remove dependencies on algebra in the `Data.List` folder except for: * `Data.List.EditDistance`: Actually relies on algebra. Maybe should be moved? * `Data.List.Card`: Completely unused and redundant. * `Data.List.Cycle`: Relies on `Fintype`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.Func`: Completely unused and redundant. * `Data.List.Lex`: That's order theory. Could be moved. * `Data.List.Prime`. That's algebra. Should definitely be moved. * `Data.List.Sym`: Relies on `Multiset`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.ToFinsupp`: That's algebra. Should definitely be moved. As a consequence, move the big operators lemmas that were in there to `Algebra.BigOperators.List.Basic`. For the lemmas that were `Nat`-specific and not about auxiliary definitions, keep a version of them in the original file but stated using `Nat.sum`. Before  After 
Contributor
|
Pull request successfully merged into master. Build succeeded: |
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
Remove dependencies on algebra in the `Data.List` folder except for: * `Data.List.EditDistance`: Actually relies on algebra. Maybe should be moved? * `Data.List.Card`: Completely unused and redundant. * `Data.List.Cycle`: Relies on `Fintype`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.Func`: Completely unused and redundant. * `Data.List.Lex`: That's order theory. Could be moved. * `Data.List.Prime`. That's algebra. Should definitely be moved. * `Data.List.Sym`: Relies on `Multiset`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.ToFinsupp`: That's algebra. Should definitely be moved. As a consequence, move the big operators lemmas that were in there to `Algebra.BigOperators.List.Basic`. For the lemmas that were `Nat`-specific and not about auxiliary definitions, keep a version of them in the original file but stated using `Nat.sum`. Before  After 
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
Remove dependencies on algebra in the `Data.List` folder except for: * `Data.List.EditDistance`: Actually relies on algebra. Maybe should be moved? * `Data.List.Card`: Completely unused and redundant. * `Data.List.Cycle`: Relies on `Fintype`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.Func`: Completely unused and redundant. * `Data.List.Lex`: That's order theory. Could be moved. * `Data.List.Prime`. That's algebra. Should definitely be moved. * `Data.List.Sym`: Relies on `Multiset`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.ToFinsupp`: That's algebra. Should definitely be moved. As a consequence, move the big operators lemmas that were in there to `Algebra.BigOperators.List.Basic`. For the lemmas that were `Nat`-specific and not about auxiliary definitions, keep a version of them in the original file but stated using `Nat.sum`. Before  After 
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
Remove dependencies on algebra in the `Data.List` folder except for: * `Data.List.EditDistance`: Actually relies on algebra. Maybe should be moved? * `Data.List.Card`: Completely unused and redundant. * `Data.List.Cycle`: Relies on `Fintype`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.Func`: Completely unused and redundant. * `Data.List.Lex`: That's order theory. Could be moved. * `Data.List.Prime`. That's algebra. Should definitely be moved. * `Data.List.Sym`: Relies on `Multiset`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.ToFinsupp`: That's algebra. Should definitely be moved. As a consequence, move the big operators lemmas that were in there to `Algebra.BigOperators.List.Basic`. For the lemmas that were `Nat`-specific and not about auxiliary definitions, keep a version of them in the original file but stated using `Nat.sum`. Before  After 
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Remove dependencies on algebra in the `Data.List` folder except for: * `Data.List.EditDistance`: Actually relies on algebra. Maybe should be moved? * `Data.List.Card`: Completely unused and redundant. * `Data.List.Cycle`: Relies on `Fintype`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.Func`: Completely unused and redundant. * `Data.List.Lex`: That's order theory. Could be moved. * `Data.List.Prime`. That's algebra. Should definitely be moved. * `Data.List.Sym`: Relies on `Multiset`, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved? * `Data.List.ToFinsupp`: That's algebra. Should definitely be moved. As a consequence, move the big operators lemmas that were in there to `Algebra.BigOperators.List.Basic`. For the lemmas that were `Nat`-specific and not about auxiliary definitions, keep a version of them in the original file but stated using `Nat.sum`. Before  After 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove dependencies on algebra in the
Data.Listfolder except for:Data.List.EditDistance: Actually relies on algebra. Maybe should be moved?Data.List.Card: Completely unused and redundant.Data.List.Cycle: Relies onFintype, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved?Data.List.Func: Completely unused and redundant.Data.List.Lex: That's order theory. Could be moved.Data.List.Prime. That's algebra. Should definitely be moved.Data.List.Sym: Relies onMultiset, which shouldn't rely on algebra but it's hard to fix right now. Maybe should be moved?Data.List.ToFinsupp: That's algebra. Should definitely be moved.As a consequence, move the big operators lemmas that were in there to
Algebra.BigOperators.List.Basic. For the lemmas that wereNat-specific and not about auxiliary definitions, keep a version of them in the original file but stated usingNat.sum.Before
After
