Skip to content

[Merged by Bors] - chore: future-proof proofs in Category/Ring/Limits#11839

Closed
kim-em wants to merge 1 commit intomasterfrom
ring_cat
Closed

[Merged by Bors] - chore: future-proof proofs in Category/Ring/Limits#11839
kim-em wants to merge 1 commit intomasterfrom
ring_cat

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Apr 2, 2024

These proofs will become slow after leanprover/lean4#3807, but with these changes there is no regression. 🤷‍♀️

@eric-wieser
Copy link
Copy Markdown
Member

Can you explain the have vs letI choice in the PR description?

@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Apr 3, 2024

Can you explain the have vs letI choice in the PR description?

People use letI for no good reason? These are props, there's no evidence inlining makes any difference here, so why make things complicated. Most of the letI in Mathlib are just from the port, and are pointless.

@RemyDegenne
Copy link
Copy Markdown
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Apr 10, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 10, 2024
These proofs will become slow after leanprover/lean4#3807, but with these changes there is no regression. 🤷‍♀️

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 10, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: future-proof proofs in Category/Ring/Limits [Merged by Bors] - chore: future-proof proofs in Category/Ring/Limits Apr 10, 2024
@mathlib-bors mathlib-bors bot closed this Apr 10, 2024
@mathlib-bors mathlib-bors bot deleted the ring_cat branch April 10, 2024 07:10
xgenereux pushed a commit that referenced this pull request Apr 15, 2024
These proofs will become slow after leanprover/lean4#3807, but with these changes there is no regression. 🤷‍♀️

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
These proofs will become slow after leanprover/lean4#3807, but with these changes there is no regression. 🤷‍♀️

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
kim-em added a commit that referenced this pull request Apr 18, 2024
These proofs will become slow after leanprover/lean4#3807, but with these changes there is no regression. 🤷‍♀️

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
These proofs will become slow after leanprover/lean4#3807, but with these changes there is no regression. 🤷‍♀️

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
callesonne pushed a commit that referenced this pull request Apr 22, 2024
These proofs will become slow after leanprover/lean4#3807, but with these changes there is no regression. 🤷‍♀️

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants