Conversation
Ruben-VandeVelde
approved these changes
Apr 2, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
I don't like it much, but it's no worse than before.
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
Member
|
bors merge I adjusted the title to make clear that the proof is not yet broken |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
This proof had two `change`s added during porting, and these produce a massive timeout after the changes in leanprover/lean4#3807. This PR replace the `change` with the appropriate `erw`, and is now fast before and after the change. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
This proof had two `change`s added during porting, and these produce a massive timeout after the changes in leanprover/lean4#3807. This PR replace the `change` with the appropriate `erw`, and is now fast before and after the change. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
This proof had two `change`s added during porting, and these produce a massive timeout after the changes in leanprover/lean4#3807. This PR replace the `change` with the appropriate `erw`, and is now fast before and after the change. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
This proof had two `change`s added during porting, and these produce a massive timeout after the changes in leanprover/lean4#3807. This PR replace the `change` with the appropriate `erw`, and is now fast before and after the change. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
This proof had two `change`s added during porting, and these produce a massive timeout after the changes in leanprover/lean4#3807. This PR replace the `change` with the appropriate `erw`, and is now fast before and after the change. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proof had two
changes added during porting, and these produce a massive timeout after the changes in leanprover/lean4#3807.This PR replace the
changewith the appropriateerw, and is now fast before and after the change.