[Merged by Bors] - chore: fix casing per naming scheme#1183
Closed
winstonyin wants to merge 9 commits intomasterfrom
Closed
[Merged by Bors] - chore: fix casing per naming scheme#1183winstonyin wants to merge 9 commits intomasterfrom
winstonyin wants to merge 9 commits intomasterfrom
Conversation
rwbarton
reviewed
Dec 23, 2022
Contributor
rwbarton
left a comment
There was a problem hiding this comment.
lgtm aside from some questions about removed \ns from to_additive docstrings.
| `Mᵐᵒᵖ →ₙ* Nᵐᵒᵖ`. This is the action of the (fully faithful) `ᵐᵒᵖ`-functor on morphisms. -/ | ||
| @[to_additive | ||
| "An additive semigroup homomorphism `add_hom M N` can equivalently be viewed as an\n | ||
| additive semigroup homomorphism `add_hom Mᵃᵒᵖ Nᵃᵒᵖ`. This is the action of the\n |
Contributor
There was a problem hiding this comment.
Are you sure these \ns should be removed?
Collaborator
Author
There was a problem hiding this comment.
I think so. The \ns were added in by mathport. See the (original mathlib3 file)[https://github.com/leanprover-community/mathlib/blob/master/src/algebra/group/opposite.lean], where new lines are inserted simply to keep the lines to within 100 characters long.
| `Mᵐᵒᵖ →* Nᵐᵒᵖ`. This is the action of the (fully faithful) `ᵐᵒᵖ`-functor on morphisms. -/ | ||
| @[to_additive | ||
| "An additive monoid homomorphism `M →+ N` can equivalently be viewed as an\n | ||
| additive monoid homomorphism `Mᵃᵒᵖ →+ Nᵃᵒᵖ`. This is the action of the (fully faithful)\n |
Contributor
|
Thanks for these fixes. Could I ask that if (or when) you have any more fixes, to please make a new PR for them? Otherwise, reviewing becomes increasingly difficult. |
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 23, 2022
Fix a lot of wrong casing mostly in the docstrings but also sometimes in def/theorem names. E.g. `fin 2 --> Fin 2`, `add_monoid_hom --> AddMonoidHom` Remove `\n` from `to_additive` docstrings that were inserted by mathport. Move files and directories with `Gcd` and `Smul` to `GCD` and `SMul`
|
Pull request successfully merged into master. Build succeeded:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a lot of wrong casing mostly in the docstrings but also sometimes in def/theorem names. E.g.
fin 2 --> Fin 2,add_monoid_hom --> AddMonoidHomRemove
\nfromto_additivedocstrings that were inserted by mathport.Move files and directories with
GcdandSmultoGCDandSMul