Skip to content

[Merged by Bors] - feat(RingTheory/Flat/Basic): add lTensor_preserves_injective_linearMap#11748

Closed
acmepjz wants to merge 2 commits intomasterfrom
acmepjz_flat_preserves_inj
Closed

[Merged by Bors] - feat(RingTheory/Flat/Basic): add lTensor_preserves_injective_linearMap#11748
acmepjz wants to merge 2 commits intomasterfrom
acmepjz_flat_preserves_inj

Conversation

@acmepjz
Copy link
Copy Markdown
Collaborator

@acmepjz acmepjz commented Mar 28, 2024

also move lTensor_inj_iff_rTensor_inj to LinearMap


Open in Gitpod

@acmepjz acmepjz added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) labels Mar 28, 2024
Copy link
Copy Markdown
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by alreadydone.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 28, 2024
@alreadydone
Copy link
Copy Markdown
Contributor

Sorry, there seems to be a build error in Flat.lean

@acmepjz
Copy link
Copy Markdown
Collaborator Author

acmepjz commented Mar 28, 2024

Sorry, there seems to be a build error in Flat.lean

Oops. I'll check now.

[EDIT] That bug is very strange; rw [LinearMap.lTensor_inj_iff_rTensor_inj] or rw [L.lTensor_inj_iff_rTensor_inj M] works, but not rw [L.lTensor_inj_iff_rTensor_inj].


Also, I marked an existing theorem as deprecated, so it's expected that there are more errors in downstream files. 😂 Now we need to find out all the occurrences of it and got them replaced.

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Mar 28, 2024
@riccardobrasca
Copy link
Copy Markdown
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Mar 29, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 29, 2024
…ap` (#11748)

also move `lTensor_inj_iff_rTensor_inj` to `LinearMap`
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 29, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory/Flat/Basic): add lTensor_preserves_injective_linearMap [Merged by Bors] - feat(RingTheory/Flat/Basic): add lTensor_preserves_injective_linearMap Mar 29, 2024
@mathlib-bors mathlib-bors bot closed this Mar 29, 2024
@mathlib-bors mathlib-bors bot deleted the acmepjz_flat_preserves_inj branch March 29, 2024 18:32
xgenereux pushed a commit that referenced this pull request Apr 15, 2024
…ap` (#11748)

also move `lTensor_inj_iff_rTensor_inj` to `LinearMap`
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
…ap` (#11748)

also move `lTensor_inj_iff_rTensor_inj` to `LinearMap`
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
…ap` (#11748)

also move `lTensor_inj_iff_rTensor_inj` to `LinearMap`
callesonne pushed a commit that referenced this pull request Apr 22, 2024
…ap` (#11748)

also move `lTensor_inj_iff_rTensor_inj` to `LinearMap`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants