Skip to content

[Merged by Bors] - feat(LinearAlgebra/TensorProduct/Basic): add LinearEquiv.(l|r)Tensor#11731

Closed
acmepjz wants to merge 14 commits intomasterfrom
acmepjz_tensor_congr
Closed

[Merged by Bors] - feat(LinearAlgebra/TensorProduct/Basic): add LinearEquiv.(l|r)Tensor#11731
acmepjz wants to merge 14 commits intomasterfrom
acmepjz_tensor_congr

Conversation

@acmepjz
Copy link
Copy Markdown
Collaborator

@acmepjz acmepjz commented Mar 27, 2024

  • add LinearMap.(l|r)Tensor and their properties
  • add congr_symm, congr_refl_refl, congr_trans, congr_mul, congr_pow and congr_zpow

Open in Gitpod

@acmepjz acmepjz added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) labels Mar 27, 2024
@acmepjz acmepjz changed the title feat(LinearAlgebra.TensorProduct.Basic): add some results on TensorProduct.congr feat(LinearAlgebra/TensorProduct/Basic): add some results on TensorProduct.congr Mar 27, 2024
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Mar 27, 2024
@acmepjz acmepjz added the easy < 20s of review time. See the lifecycle page for guidelines. label Mar 28, 2024
@acmepjz acmepjz requested a review from alreadydone March 30, 2024 00:23
@acmepjz
Copy link
Copy Markdown
Collaborator Author

acmepjz commented Mar 30, 2024

But maybe it's more appropriate to introduce LinearEquiv.lTensor/rTensor.

I think you're right; let me check it later.

Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
@acmepjz acmepjz removed the easy < 20s of review time. See the lifecycle page for guidelines. label Mar 30, 2024
@acmepjz acmepjz changed the title feat(LinearAlgebra/TensorProduct/Basic): add some results on TensorProduct.congr feat(LinearAlgebra/TensorProduct/Basic): add LinearEquiv.(l|r)Tensor Mar 30, 2024
@acmepjz
Copy link
Copy Markdown
Collaborator Author

acmepjz commented Mar 30, 2024

Ooos, file is too long :(

@acmepjz
Copy link
Copy Markdown
Collaborator Author

acmepjz commented Mar 30, 2024

I have no idea why Mathlib/Algebra/Category/ModuleCat/Monoidal/Basic.lean breaks. Seems that LinearMap.lTensor does not work anymore.

@acmepjz
Copy link
Copy Markdown
Collaborator Author

acmepjz commented Mar 31, 2024

It looks like that merely adding the definition LinearEquiv.lTensor breaks that file.

Copy link
Copy Markdown
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(assoc R W X Y).rTensor Z needs to be changed to (assoc R W X Y).toLinearMap.rTensor Z. assoc R W X Y was automatically coerced to a LinearMap, but now rTensor has another interpretation.

@acmepjz acmepjz changed the title feat(LinearAlgebra/TensorProduct/Basic): add LinearEquiv.(l|r)Tensor feat(LinearAlgebra/TensorProduct/Basic): add LinearEquiv.(l|r)Tensor and reduce the number of lines Mar 31, 2024
@acmepjz acmepjz changed the title feat(LinearAlgebra/TensorProduct/Basic): add LinearEquiv.(l|r)Tensor and reduce the number of lines feat(LinearAlgebra/TensorProduct/Basic): add LinearEquiv.(l|r)Tensor Apr 2, 2024
@acmepjz acmepjz requested a review from alreadydone April 16, 2024 22:46
Copy link
Copy Markdown
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by alreadydone.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 17, 2024
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Apr 25, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 25, 2024
#11731)

- add `LinearMap.(l|r)Tensor` and their properties
- add `congr_symm`, `congr_refl_refl`, `congr_trans`, `congr_mul`, `congr_pow` and `congr_zpow`
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 25, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(LinearAlgebra/TensorProduct/Basic): add LinearEquiv.(l|r)Tensor [Merged by Bors] - feat(LinearAlgebra/TensorProduct/Basic): add LinearEquiv.(l|r)Tensor Apr 25, 2024
@mathlib-bors mathlib-bors bot closed this Apr 25, 2024
@mathlib-bors mathlib-bors bot deleted the acmepjz_tensor_congr branch April 25, 2024 16:11
apnelson1 pushed a commit that referenced this pull request May 12, 2024
#11731)

- add `LinearMap.(l|r)Tensor` and their properties
- add `congr_symm`, `congr_refl_refl`, `congr_trans`, `congr_mul`, `congr_pow` and `congr_zpow`
callesonne pushed a commit that referenced this pull request May 16, 2024
#11731)

- add `LinearMap.(l|r)Tensor` and their properties
- add `congr_symm`, `congr_refl_refl`, `congr_trans`, `congr_mul`, `congr_pow` and `congr_zpow`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants