Skip to content

[Merged by Bors] - feat(LinearAlgebra/DirectSum/Finsupp): add some more variants of finsuppTensorFinsupp#11598

Closed
acmepjz wants to merge 8 commits intomasterfrom
acmepjz_finsupp_tensor
Closed

[Merged by Bors] - feat(LinearAlgebra/DirectSum/Finsupp): add some more variants of finsuppTensorFinsupp#11598
acmepjz wants to merge 8 commits intomasterfrom
acmepjz_finsupp_tensor

Conversation

@acmepjz
Copy link
Copy Markdown
Collaborator

@acmepjz acmepjz commented Mar 23, 2024

  • add finsuppTensorFinsuppLid, finsuppTensorFinsuppRid as well as their simp lemmas
  • make finsuppTensorFinsupp' a special case of finsuppTensorFinsuppLid
  • add TensorProduct.lid_eq_rid

Open in Gitpod

Related: https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/Linearly.20disjoint/near/411691388

does not depend on: #10824 #11635 [probably?]

@acmepjz acmepjz added WIP Work in progress awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) labels Mar 23, 2024
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Mar 23, 2024
@ghost ghost added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Mar 23, 2024
@acmepjz acmepjz marked this pull request as ready for review March 23, 2024 17:30
@acmepjz acmepjz added awaiting-review and removed WIP Work in progress labels Mar 23, 2024
@ghost ghost removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Mar 23, 2024
Copy link
Copy Markdown
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM
maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by alreadydone.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 28, 2024
@ocfnash
Copy link
Copy Markdown
Contributor

ocfnash commented Mar 28, 2024

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Mar 28, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 28, 2024
…suppTensorFinsupp` (#11598)

- add `finsuppTensorFinsuppLid`, `finsuppTensorFinsuppRid` as well as their simp lemmas
- make `finsuppTensorFinsupp'` a special case of `finsuppTensorFinsuppLid`
- add `TensorProduct.lid_eq_rid`
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 28, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(LinearAlgebra/DirectSum/Finsupp): add some more variants of finsuppTensorFinsupp [Merged by Bors] - feat(LinearAlgebra/DirectSum/Finsupp): add some more variants of finsuppTensorFinsupp Mar 28, 2024
@mathlib-bors mathlib-bors bot closed this Mar 28, 2024
@mathlib-bors mathlib-bors bot deleted the acmepjz_finsupp_tensor branch March 28, 2024 11:36
xgenereux pushed a commit that referenced this pull request Apr 15, 2024
…suppTensorFinsupp` (#11598)

- add `finsuppTensorFinsuppLid`, `finsuppTensorFinsuppRid` as well as their simp lemmas
- make `finsuppTensorFinsupp'` a special case of `finsuppTensorFinsuppLid`
- add `TensorProduct.lid_eq_rid`
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
…suppTensorFinsupp` (#11598)

- add `finsuppTensorFinsuppLid`, `finsuppTensorFinsuppRid` as well as their simp lemmas
- make `finsuppTensorFinsupp'` a special case of `finsuppTensorFinsuppLid`
- add `TensorProduct.lid_eq_rid`
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
…suppTensorFinsupp` (#11598)

- add `finsuppTensorFinsuppLid`, `finsuppTensorFinsuppRid` as well as their simp lemmas
- make `finsuppTensorFinsupp'` a special case of `finsuppTensorFinsuppLid`
- add `TensorProduct.lid_eq_rid`
callesonne pushed a commit that referenced this pull request Apr 22, 2024
…suppTensorFinsupp` (#11598)

- add `finsuppTensorFinsuppLid`, `finsuppTensorFinsuppRid` as well as their simp lemmas
- make `finsuppTensorFinsupp'` a special case of `finsuppTensorFinsuppLid`
- add `TensorProduct.lid_eq_rid`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants