Skip to content

[Merged by Bors] - chore: Homogenise instances for MulOpposite/AddOpposite#11485

Closed
YaelDillies wants to merge 13 commits intomasterfrom
cleanup_opposite_instances
Closed

[Merged by Bors] - chore: Homogenise instances for MulOpposite/AddOpposite#11485
YaelDillies wants to merge 13 commits intomasterfrom
cleanup_opposite_instances

Conversation

@YaelDillies
Copy link
Copy Markdown
Contributor

by declaring them all in where style with implicit type assumptions and inst prefix

Here to reduce the diff from #11203


Open in Gitpod

@YaelDillies YaelDillies added awaiting-review t-algebra Algebra (groups, rings, fields, etc) labels Mar 18, 2024
@eric-wieser
Copy link
Copy Markdown
Member

!bench

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit ebe0549.
There were no significant changes against commit 6aee244.

@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Mar 19, 2024
@YaelDillies YaelDillies added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Mar 19, 2024
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 20, 2024
@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 20, 2024
@fpvandoorn
Copy link
Copy Markdown
Member

bors merge
bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 5, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Apr 5, 2024
mathlib-bors bot pushed a commit that referenced this pull request Apr 5, 2024
by declaring them all in `where` style with implicit type assumptions and `inst` prefix

Here to reduce the diff from #11203
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 5, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Apr 5, 2024
by declaring them all in `where` style with implicit type assumptions and `inst` prefix

Here to reduce the diff from #11203
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 5, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Apr 5, 2024
by declaring them all in `where` style with implicit type assumptions and `inst` prefix

Here to reduce the diff from #11203
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 5, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Homogenise instances for MulOpposite/AddOpposite [Merged by Bors] - chore: Homogenise instances for MulOpposite/AddOpposite Apr 5, 2024
@mathlib-bors mathlib-bors bot closed this Apr 5, 2024
@mathlib-bors mathlib-bors bot deleted the cleanup_opposite_instances branch April 5, 2024 18:00
xgenereux pushed a commit that referenced this pull request Apr 15, 2024
by declaring them all in `where` style with implicit type assumptions and `inst` prefix

Here to reduce the diff from #11203
atarnoam pushed a commit that referenced this pull request Apr 16, 2024
by declaring them all in `where` style with implicit type assumptions and `inst` prefix

Here to reduce the diff from #11203
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
by declaring them all in `where` style with implicit type assumptions and `inst` prefix

Here to reduce the diff from #11203
callesonne pushed a commit that referenced this pull request Apr 22, 2024
by declaring them all in `where` style with implicit type assumptions and `inst` prefix

Here to reduce the diff from #11203
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants