Closed
Conversation
YaelDillies
reviewed
Mar 14, 2024
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit beec5dc. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
More tactics that are not used, found using the linter at #11308. The PR consists of tactic removals, whitespace changes and replacing a porting note by an explanation.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
More tactics that are not used, found using the linter at #11308. The PR consists of tactic removals, whitespace changes and replacing a porting note by an explanation.
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
More tactics that are not used, found using the linter at #11308. The PR consists of tactic removals, whitespace changes and replacing a porting note by an explanation.
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
More tactics that are not used, found using the linter at #11308. The PR consists of tactic removals, whitespace changes and replacing a porting note by an explanation.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
More tactics that are not used, found using the linter at #11308. The PR consists of tactic removals, whitespace changes and replacing a porting note by an explanation.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
More tactics that are not used, found using the linter at #11308. The PR consists of tactic removals, whitespace changes and replacing a porting note by an explanation.
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 30, 2024
The `unusedTactic` linter emits a warning if a tactic does nothing. Previous PRs (see below) removed all the "unused tactics" that the linter flagged. Here is an overview of this PR: * the linter is defined in `Mathlib/Tactic/Linter/UnusedTactic.lean`; * the file `Mathlib/GroupTheory/Perm/Cycle/Concrete.lean` contains the "only" `set_option` to opt out of the linter, since it defines notation that uses `decide` that the notation itself does not use; * 17 test files that have surgically opted out of the linter; * noise to import the new file, place it low in the import hierarchy and update `noshake`. PRs removing some unused tactics: * #11333 * #11351 * #11365 * #11379 [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/pointless.20tactic.20linter)
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
The `unusedTactic` linter emits a warning if a tactic does nothing. Previous PRs (see below) removed all the "unused tactics" that the linter flagged. Here is an overview of this PR: * the linter is defined in `Mathlib/Tactic/Linter/UnusedTactic.lean`; * the file `Mathlib/GroupTheory/Perm/Cycle/Concrete.lean` contains the "only" `set_option` to opt out of the linter, since it defines notation that uses `decide` that the notation itself does not use; * 17 test files that have surgically opted out of the linter; * noise to import the new file, place it low in the import hierarchy and update `noshake`. PRs removing some unused tactics: * #11333 * #11351 * #11365 * #11379 [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/pointless.20tactic.20linter)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More tactics that are not used, found using the linter at #11308.
The PR consists of tactic removals, whitespace changes and replacing a porting note by an explanation.