[Merged by Bors] - refactor: do not allow qsmul to default automatically#11262
Closed
eric-wieser wants to merge 7 commits intomasterfrom
Closed
[Merged by Bors] - refactor: do not allow qsmul to default automatically#11262eric-wieser wants to merge 7 commits intomasterfrom
qsmul to default automatically#11262eric-wieser wants to merge 7 commits intomasterfrom
Conversation
Contributor
|
!bench |
mattrobball
approved these changes
Mar 9, 2024
| mul_inv_cancel x := CauSeq.Completion.mul_inv_cancel | ||
| ratCast q := ofRat q | ||
| ratCast_mk n d hd hnd := by rw [← ofRat_ratCast, Rat.cast_mk', ofRat_mul, ofRat_inv]; rfl | ||
| qsmul := qsmulRec _ -- TODO: fix instance diamond |
Contributor
There was a problem hiding this comment.
Maybe make a separate issue or add to an existing one.
Collaborator
|
Here are the benchmark results for commit cb4d250. Benchmark Metric Change
==========================================================
+ build linting -5.6%
+ ~Mathlib.RingTheory.IntegralDomain instructions -39.7% |
eric-wieser
commented
Mar 9, 2024
| can be found in `Mathlib.RingTheory.LittleWedderburn`. -/ | ||
| def Fintype.fieldOfDomain (R) [CommRing R] [IsDomain R] [DecidableEq R] [Fintype R] : Field R := | ||
| { Fintype.groupWithZeroOfCancel R, ‹CommRing R› with } | ||
| { Fintype.divisionRingOfIsDomain R, ‹CommRing R› with } |
Member
Author
There was a problem hiding this comment.
I guess this caused the speedup?
This was referenced Mar 9, 2024
Contributor
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 9, 2024
Follows on from #6262. Again, this does not attempt to fix any diamonds; it only identifies where they may be.
Contributor
|
Is that PR the start of the doom of Type-valued default fields? |
Member
Author
|
For now I think it's only the ones involved in diamonds that matter. There'd be no benefit to changing |
Member
Author
|
|
Contributor
|
Pull request successfully merged into master. Build succeeded: |
qsmul to default automaticallyqsmul to default automatically
kbuzzard
pushed a commit
that referenced
this pull request
Mar 12, 2024
Follows on from #6262. Again, this does not attempt to fix any diamonds; it only identifies where they may be.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
Follows on from #6262. Again, this does not attempt to fix any diamonds; it only identifies where they may be.
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
Follows on from #6262. Again, this does not attempt to fix any diamonds; it only identifies where they may be.
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
Follows on from #6262. Again, this does not attempt to fix any diamonds; it only identifies where they may be.
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
Follows on from #6262. Again, this does not attempt to fix any diamonds; it only identifies where they may be.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
Follows on from #6262. Again, this does not attempt to fix any diamonds; it only identifies where they may be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows on from #6262.
Again, this does not attempt to fix any diamonds; it only identifies where they may be.