Skip to content

[Merged by Bors] - chore: squeeze some non-terminal simps#11247

Closed
adomani wants to merge 3 commits intomasterfrom
adomani/squeeze_simps
Closed

[Merged by Bors] - chore: squeeze some non-terminal simps#11247
adomani wants to merge 3 commits intomasterfrom
adomani/squeeze_simps

Conversation

@adomani
Copy link
Copy Markdown
Contributor

@adomani adomani commented Mar 8, 2024

This PR accompanies #11246, squeezing some non-terminal simps highlighted by the linter until I decided to stop!


Open in Gitpod

@mattrobball
Copy link
Copy Markdown
Contributor

!bench

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Here are the benchmark results for commit 3d2d08a.
There were no significant changes against commit 0c4cb82.

Copy link
Copy Markdown
Contributor

@mattrobball mattrobball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks.

@mattrobball
Copy link
Copy Markdown
Contributor

Can you address the small comment first?

bors delegate+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 8, 2024

✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@adomani
Copy link
Copy Markdown
Contributor Author

adomani commented Mar 8, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Mar 8, 2024
This PR accompanies #11246, squeezing some non-terminal `simp`s highlighted by the linter until I decided to stop!
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 8, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: squeeze some non-terminal simps [Merged by Bors] - chore: squeeze some non-terminal simps Mar 8, 2024
@mathlib-bors mathlib-bors bot closed this Mar 8, 2024
@mathlib-bors mathlib-bors bot deleted the adomani/squeeze_simps branch March 8, 2024 23:09
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
This PR accompanies #11246, squeezing some non-terminal `simp`s highlighted by the linter until I decided to stop!
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
This PR accompanies #11246, squeezing some non-terminal `simp`s highlighted by the linter until I decided to stop!
utensil pushed a commit that referenced this pull request Mar 26, 2024
This PR accompanies #11246, squeezing some non-terminal `simp`s highlighted by the linter until I decided to stop!
xgenereux pushed a commit that referenced this pull request Apr 15, 2024
This PR accompanies #11246, squeezing some non-terminal `simp`s highlighted by the linter until I decided to stop!
uniwuni pushed a commit that referenced this pull request Apr 19, 2024
This PR accompanies #11246, squeezing some non-terminal `simp`s highlighted by the linter until I decided to stop!
callesonne pushed a commit that referenced this pull request Apr 22, 2024
This PR accompanies #11246, squeezing some non-terminal `simp`s highlighted by the linter until I decided to stop!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants