[Merged by Bors] - chore(Algebra/Group): Do not import GroupWithZero#11202
Closed
YaelDillies wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - chore(Algebra/Group): Do not import GroupWithZero#11202YaelDillies wants to merge 4 commits intomasterfrom
GroupWithZero#11202YaelDillies wants to merge 4 commits intomasterfrom
Conversation
I am claiming that anything within the `Algebra.Group` folder should be additivisable, to the exception of `MonoidHom.End` maybe. This is not the case of `NeZero`, `MonoidWithZero` and `MonoidWithZeroHom` which were all imported to prove a few lemmas. Those lemmas are easily moved to another file.
12 tasks
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
I am claiming that anything within the `Algebra.Group` folder should be additivisable, to the exception of `MonoidHom.End` maybe. This is not the case of `NeZero`, `MonoidWithZero` and `MonoidWithZeroHom` which were all imported to prove a few lemmas. Those lemmas are easily moved to another file.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
GroupWithZeroGroupWithZero
kbuzzard
pushed a commit
that referenced
this pull request
Mar 12, 2024
I am claiming that anything within the `Algebra.Group` folder should be additivisable, to the exception of `MonoidHom.End` maybe. This is not the case of `NeZero`, `MonoidWithZero` and `MonoidWithZeroHom` which were all imported to prove a few lemmas. Those lemmas are easily moved to another file.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
I am claiming that anything within the `Algebra.Group` folder should be additivisable, to the exception of `MonoidHom.End` maybe. This is not the case of `NeZero`, `MonoidWithZero` and `MonoidWithZeroHom` which were all imported to prove a few lemmas. Those lemmas are easily moved to another file.
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
I am claiming that anything within the `Algebra.Group` folder should be additivisable, to the exception of `MonoidHom.End` maybe. This is not the case of `NeZero`, `MonoidWithZero` and `MonoidWithZeroHom` which were all imported to prove a few lemmas. Those lemmas are easily moved to another file.
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
I am claiming that anything within the `Algebra.Group` folder should be additivisable, to the exception of `MonoidHom.End` maybe. This is not the case of `NeZero`, `MonoidWithZero` and `MonoidWithZeroHom` which were all imported to prove a few lemmas. Those lemmas are easily moved to another file.
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
I am claiming that anything within the `Algebra.Group` folder should be additivisable, to the exception of `MonoidHom.End` maybe. This is not the case of `NeZero`, `MonoidWithZero` and `MonoidWithZeroHom` which were all imported to prove a few lemmas. Those lemmas are easily moved to another file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am claiming that anything within the
Algebra.Groupfolder should be additivisable, to the exception ofMonoidHom.Endmaybe. This is not the case ofNeZero,MonoidWithZeroandMonoidWithZeroHomwhich were all imported to prove a few lemmas. Those lemmas are easily moved to another file.