Skip to content

[Merged by Bors] - style: homogenise porting notes#11145

Closed
pitmonticone wants to merge 3 commits intomasterfrom
pitmonticone/homogenise-porting-notes
Closed

[Merged by Bors] - style: homogenise porting notes#11145
pitmonticone wants to merge 3 commits intomasterfrom
pitmonticone/homogenise-porting-notes

Conversation

@pitmonticone
Copy link
Copy Markdown
Member

@pitmonticone pitmonticone commented Mar 4, 2024

Homogenises porting notes via capitalisation and addition of whitespace.

It makes the following changes:

  • converts "--porting note" into "-- Porting note";
  • converts "porting note" into "Porting note".

@pitmonticone pitmonticone added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. porting-notes Mathlib3 to Mathlib4 porting notes. labels Mar 4, 2024
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 4, 2024
@jcommelin
Copy link
Copy Markdown
Member

Please fix the conflicts, and after CI passes, kick it on the queue

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 4, 2024

✌️ pitmonticone can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed awaiting-review labels Mar 4, 2024
@pitmonticone
Copy link
Copy Markdown
Member Author

bors r+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 4, 2024

👎 Rejected by label

@ghost ghost removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 4, 2024
@pitmonticone
Copy link
Copy Markdown
Member Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Mar 4, 2024
Homogenises porting notes via capitalisation and addition of whitespace.

It makes the following changes:
- converts "--porting note" into "-- Porting note";
- converts "porting note" into "Porting note".
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 4, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title style: homogenise porting notes [Merged by Bors] - style: homogenise porting notes Mar 4, 2024
@mathlib-bors mathlib-bors bot closed this Mar 4, 2024
@mathlib-bors mathlib-bors bot deleted the pitmonticone/homogenise-porting-notes branch March 4, 2024 15:47
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
Homogenises porting notes via capitalisation and addition of whitespace.

It makes the following changes:
- converts "--porting note" into "-- Porting note";
- converts "porting note" into "Porting note".
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Homogenises porting notes via capitalisation and addition of whitespace.

It makes the following changes:
- converts "--porting note" into "-- Porting note";
- converts "porting note" into "Porting note".
utensil pushed a commit that referenced this pull request Mar 26, 2024
Homogenises porting notes via capitalisation and addition of whitespace.

It makes the following changes:
- converts "--porting note" into "-- Porting note";
- converts "porting note" into "Porting note".
xgenereux pushed a commit that referenced this pull request Apr 15, 2024
Homogenises porting notes via capitalisation and addition of whitespace.

It makes the following changes:
- converts "--porting note" into "-- Porting note";
- converts "porting note" into "Porting note".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines. porting-notes Mathlib3 to Mathlib4 porting notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants