Skip to content

[Merged by Bors] - feat: funext_iff_of_subsingleton#11140

Closed
jsm28 wants to merge 1 commit intomasterfrom
jsm28/funext_iff_of_subsingleton
Closed

[Merged by Bors] - feat: funext_iff_of_subsingleton#11140
jsm28 wants to merge 1 commit intomasterfrom
jsm28/funext_iff_of_subsingleton

Conversation

@jsm28
Copy link
Copy Markdown
Contributor

@jsm28 jsm28 commented Mar 3, 2024

Add a lemma about equality of functions from a subsingleton type:

lemma funext_iff_of_subsingleton [Subsingleton α] {g : α → β} (x y : α) :
    f x = g y ↔ f = g := by

This isn't a simp lemma; it isn't entirely clear whether equality of functions or of particular values should necessarily be considered simpler, and making it a simp lemma introduces a simpNF linter failure for eq_rec_inj.

From AperiodicMonotilesLean.


Open in Gitpod

Add a lemma about equality of functions from a subsingleton type:

```lean
lemma funext_iff_of_subsingleton [Subsingleton α] {g : α → β} (x y : α) :
    f x = g y ↔ f = g := by
```

This isn't a `simp` lemma; it isn't entirely clear whether equality of
functions or of particular values should necessarily be considered
simpler, and making it a `simp` lemma introduces a `simpNF` linter
failure for `eq_rec_inj`.

From AperiodicMonotilesLean.
@jsm28 jsm28 added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. labels Mar 3, 2024
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Mar 5, 2024
mathlib-bors bot pushed a commit that referenced this pull request Mar 5, 2024
Add a lemma about equality of functions from a subsingleton type:

```lean
lemma funext_iff_of_subsingleton [Subsingleton α] {g : α → β} (x y : α) :
    f x = g y ↔ f = g := by
```

This isn't a `simp` lemma; it isn't entirely clear whether equality of functions or of particular values should necessarily be considered simpler, and making it a `simp` lemma introduces a `simpNF` linter failure for `eq_rec_inj`.

From AperiodicMonotilesLean.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 5, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: funext_iff_of_subsingleton [Merged by Bors] - feat: funext_iff_of_subsingleton Mar 5, 2024
@mathlib-bors mathlib-bors bot closed this Mar 5, 2024
@mathlib-bors mathlib-bors bot deleted the jsm28/funext_iff_of_subsingleton branch March 5, 2024 14:11
kbuzzard pushed a commit that referenced this pull request Mar 12, 2024
Add a lemma about equality of functions from a subsingleton type:

```lean
lemma funext_iff_of_subsingleton [Subsingleton α] {g : α → β} (x y : α) :
    f x = g y ↔ f = g := by
```

This isn't a `simp` lemma; it isn't entirely clear whether equality of functions or of particular values should necessarily be considered simpler, and making it a `simp` lemma introduces a `simpNF` linter failure for `eq_rec_inj`.

From AperiodicMonotilesLean.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Add a lemma about equality of functions from a subsingleton type:

```lean
lemma funext_iff_of_subsingleton [Subsingleton α] {g : α → β} (x y : α) :
    f x = g y ↔ f = g := by
```

This isn't a `simp` lemma; it isn't entirely clear whether equality of functions or of particular values should necessarily be considered simpler, and making it a `simp` lemma introduces a `simpNF` linter failure for `eq_rec_inj`.

From AperiodicMonotilesLean.
utensil pushed a commit that referenced this pull request Mar 26, 2024
Add a lemma about equality of functions from a subsingleton type:

```lean
lemma funext_iff_of_subsingleton [Subsingleton α] {g : α → β} (x y : α) :
    f x = g y ↔ f = g := by
```

This isn't a `simp` lemma; it isn't entirely clear whether equality of functions or of particular values should necessarily be considered simpler, and making it a `simp` lemma introduces a `simpNF` linter failure for `eq_rec_inj`.

From AperiodicMonotilesLean.
xgenereux pushed a commit that referenced this pull request Apr 15, 2024
Add a lemma about equality of functions from a subsingleton type:

```lean
lemma funext_iff_of_subsingleton [Subsingleton α] {g : α → β} (x y : α) :
    f x = g y ↔ f = g := by
```

This isn't a `simp` lemma; it isn't entirely clear whether equality of functions or of particular values should necessarily be considered simpler, and making it a `simp` lemma introduces a `simpNF` linter failure for `eq_rec_inj`.

From AperiodicMonotilesLean.
callesonne pushed a commit that referenced this pull request Apr 22, 2024
Add a lemma about equality of functions from a subsingleton type:

```lean
lemma funext_iff_of_subsingleton [Subsingleton α] {g : α → β} (x y : α) :
    f x = g y ↔ f = g := by
```

This isn't a `simp` lemma; it isn't entirely clear whether equality of functions or of particular values should necessarily be considered simpler, and making it a `simp` lemma introduces a `simpNF` linter failure for `eq_rec_inj`.

From AperiodicMonotilesLean.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants