[Merged by Bors] - chore: backport a few misc changes from #11070 to master#11079
Closed
[Merged by Bors] - chore: backport a few misc changes from #11070 to master#11079
Conversation
jcommelin
approved these changes
Mar 1, 2024
Member
jcommelin
left a comment
There was a problem hiding this comment.
Thanks 🎉
If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.
bors d+
Contributor
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
Contributor
Author
|
Thanks for the quick review. |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
A random collection of changes, backporting from the upcoming Lean bump. - squeeze one simp - backport one more simp change (which probably was missed in the previous backports) - rewrite the `field_simp` in SolutionOfCubic: with the upcoming Lean bump, this would become **very** slow Similar to #10996 and #11001.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
riccardobrasca
pushed a commit
that referenced
this pull request
Mar 1, 2024
A random collection of changes, backporting from the upcoming Lean bump. - squeeze one simp - backport one more simp change (which probably was missed in the previous backports) - rewrite the `field_simp` in SolutionOfCubic: with the upcoming Lean bump, this would become **very** slow Similar to #10996 and #11001.
kbuzzard
pushed a commit
that referenced
this pull request
Mar 12, 2024
A random collection of changes, backporting from the upcoming Lean bump. - squeeze one simp - backport one more simp change (which probably was missed in the previous backports) - rewrite the `field_simp` in SolutionOfCubic: with the upcoming Lean bump, this would become **very** slow Similar to #10996 and #11001.
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
A random collection of changes, backporting from the upcoming Lean bump. - squeeze one simp - backport one more simp change (which probably was missed in the previous backports) - rewrite the `field_simp` in SolutionOfCubic: with the upcoming Lean bump, this would become **very** slow Similar to #10996 and #11001.
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
A random collection of changes, backporting from the upcoming Lean bump. - squeeze one simp - backport one more simp change (which probably was missed in the previous backports) - rewrite the `field_simp` in SolutionOfCubic: with the upcoming Lean bump, this would become **very** slow Similar to #10996 and #11001.
xgenereux
pushed a commit
that referenced
this pull request
Apr 15, 2024
A random collection of changes, backporting from the upcoming Lean bump. - squeeze one simp - backport one more simp change (which probably was missed in the previous backports) - rewrite the `field_simp` in SolutionOfCubic: with the upcoming Lean bump, this would become **very** slow Similar to #10996 and #11001.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A random collection of changes, backporting from the upcoming Lean bump.
field_simpin SolutionOfCubic: with the upcoming Lean bump, this would become very slowSimilar to #10996 and #11001.